You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/05/05 10:30:20 UTC

[GitHub] [pinot] saurabhd336 commented on a diff in pull request #8601: Add support for indexes during offline segment creation

saurabhd336 commented on code in PR #8601:
URL: https://github.com/apache/pinot/pull/8601#discussion_r865766021


##########
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/IndexingConfig.java:
##########
@@ -64,6 +64,7 @@ public class IndexingConfig extends BaseJsonConfig {
   // TODO: Add a new configuration related to the segment generation
   private boolean _autoGeneratedInvertedIndex;
   private boolean _createInvertedIndexDuringSegmentGeneration;
+  private boolean _createBloomFilterDuringSegmentGeneration;

Review Comment:
   Have enabled bloomFilter and range index creation by default. Inverted index however, still gets created only through the config flag.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org