You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by Leif Hedstrom <zw...@apache.org> on 2015/11/17 19:29:17 UTC

[IMPORTANT] github pull requests for all code contributions

Hi all,

we have a proposal that all code commits going forward goes through a step of Github pull requests. This is how we typically deal with non-committer contributions, but we’d like to extend this workflow to *all* commits. Further documentation for this will be added soon, but the basic steps are:

	1. File a Jira ticket (no change here)

	2. Create a branch in a github fork of https://github.com/apache/trafficserver <https://github.com/apache/trafficserver>, name the branch e.g. TS-1234.
	
	3. Format your code with make clang-format (see https://cwiki.apache.org/confluence/display/TS/Coding+Style#CodingStyle-clang-formatbinaryandconfiguration <https://cwiki.apache.org/confluence/display/TS/Coding+Style#CodingStyle-clang-formatbinaryandconfiguration>)

	4. Run tests and regressions (at least make test and traffic_server -R 1, and ideally tsqa)

	5. Create a pull request


This applies to everyone, committer or not. If you have concerns about this, voice those now. If there are no objections or major concerns, we’ll make this the required workflow starting Monday November 23.

Cheers,

— Leif and Brian G.

Re: github pull requests for all code contributions

Posted by Leif Hedstrom <zw...@apache.org>.
> On Nov 17, 2015, at 3:11 PM, Nick Kew <ni...@apache.org> wrote:
> 
> On Tue, 17 Nov 2015 10:29:17 -0800
> Leif Hedstrom <zw...@apache.org> wrote:
> 
>> Hi all,
>> 
>> we have a proposal that all code commits going forward goes through a step of Github pull requests.
> 
> I'm happy with that in principle.  Reads like a classic github workflow.
> 
> But this reads like a decision that's been made and is being passed down.
> Did I miss on-list discussion leading to it?


No email discussion, just asking for lazy consensus here, to formalize an existing process to include everyone. If you feel we need a vote or discussion on the list, that is of course reasonable.

Cheers,

— Leif


Re: github pull requests for all code contributions

Posted by Leif Hedstrom <zw...@apache.org>.

> On Nov 18, 2015, at 1:23 PM, Miles Libbey <ml...@apache.org> wrote:
> 
> There was some mention of not requiring this for documentation (and something else?) on the irc channel.  Should this apply to only code submissions? 

I think those existing exceptions are fine. We should continue to use common sense and good judgement IMO.

Cheers,

-- Leif 
> 
> 
>    On Wednesday, November 18, 2015 11:08 AM, Thomas Jackson <ja...@gmail.com> wrote:
> 
> 
> Once this process is in "officially" I can set up some subset of jenkins
> tests to run on opened/updated PRs. We could (for example) run a clang
> check, regression, and tsqa on centos. The goal would not be complete
> coverage, but some output to give the reviewer some more confidence it will
> work. This would mimic what I see for some of the other OpenSource projects
> I work on, and I'd be glad to take the time to set it up :)
> 
>> On Tue, Nov 17, 2015 at 4:33 PM, Leif Hedstrom <zw...@apache.org> wrote:
>> 
>> 
>>> On Nov 17, 2015, at 3:11 PM, Nick Kew <ni...@apache.org> wrote:
>>> 
>>> On Tue, 17 Nov 2015 10:29:17 -0800
>>> Leif Hedstrom <zw...@apache.org> wrote:
>>> 
>>>> Hi all,
>>>> 
>>>> we have a proposal that all code commits going forward goes through a
>> step of Github pull requests.
>>> 
>>> I'm happy with that in principle.  Reads like a classic github workflow.
>>> 
>>> But this reads like a decision that's been made and is being passed down.
>>> Did I miss on-list discussion leading to it?
>> 
>> 
>> 
>> Also, lets consider this thread the discussion thread :).
>> 
>> — Leif
> 

Re: github pull requests for all code contributions

Posted by Miles Libbey <ml...@apache.org>.
There was some mention of not requiring this for documentation (and something else?) on the irc channel.  Should this apply to only code submissions? 


    On Wednesday, November 18, 2015 11:08 AM, Thomas Jackson <ja...@gmail.com> wrote:
 

 Once this process is in "officially" I can set up some subset of jenkins
tests to run on opened/updated PRs. We could (for example) run a clang
check, regression, and tsqa on centos. The goal would not be complete
coverage, but some output to give the reviewer some more confidence it will
work. This would mimic what I see for some of the other OpenSource projects
I work on, and I'd be glad to take the time to set it up :)

On Tue, Nov 17, 2015 at 4:33 PM, Leif Hedstrom <zw...@apache.org> wrote:

>
> > On Nov 17, 2015, at 3:11 PM, Nick Kew <ni...@apache.org> wrote:
> >
> > On Tue, 17 Nov 2015 10:29:17 -0800
> > Leif Hedstrom <zw...@apache.org> wrote:
> >
> >> Hi all,
> >>
> >> we have a proposal that all code commits going forward goes through a
> step of Github pull requests.
> >
> > I'm happy with that in principle.  Reads like a classic github workflow.
> >
> > But this reads like a decision that's been made and is being passed down.
> > Did I miss on-list discussion leading to it?
>
>
>
> Also, lets consider this thread the discussion thread :).
>
> — Leif
>
>

  

Re: github pull requests for all code contributions

Posted by Leif Hedstrom <zw...@apache.org>.
Cool. Can you host these Jenkins instances on LinkedIn hardware? Or perhaps on Travis or some other free service? There is unfortunately no way we can safely do this automated on the RackSpace donated VMs. A possible solution is a manual process, where a committer can allow a PR to run on our CI after careful review.

Cheers,

-- Leif 

> On Nov 18, 2015, at 9:08 AM, Thomas Jackson <ja...@gmail.com> wrote:
> 
> Once this process is in "officially" I can set up some subset of jenkins
> tests to run on opened/updated PRs. We could (for example) run a clang
> check, regression, and tsqa on centos. The goal would not be complete
> coverage, but some output to give the reviewer some more confidence it will
> work. This would mimic what I see for some of the other OpenSource projects
> I work on, and I'd be glad to take the time to set it up :)
> 
>> On Tue, Nov 17, 2015 at 4:33 PM, Leif Hedstrom <zw...@apache.org> wrote:
>> 
>> 
>>> On Nov 17, 2015, at 3:11 PM, Nick Kew <ni...@apache.org> wrote:
>>> 
>>> On Tue, 17 Nov 2015 10:29:17 -0800
>>> Leif Hedstrom <zw...@apache.org> wrote:
>>> 
>>>> Hi all,
>>>> 
>>>> we have a proposal that all code commits going forward goes through a
>> step of Github pull requests.
>>> 
>>> I'm happy with that in principle.  Reads like a classic github workflow.
>>> 
>>> But this reads like a decision that's been made and is being passed down.
>>> Did I miss on-list discussion leading to it?
>> 
>> 
>> 
>> Also, lets consider this thread the discussion thread :).
>> 
>> — Leif
>> 
>> 

Re: github pull requests for all code contributions

Posted by Thomas Jackson <ja...@gmail.com>.
Once this process is in "officially" I can set up some subset of jenkins
tests to run on opened/updated PRs. We could (for example) run a clang
check, regression, and tsqa on centos. The goal would not be complete
coverage, but some output to give the reviewer some more confidence it will
work. This would mimic what I see for some of the other OpenSource projects
I work on, and I'd be glad to take the time to set it up :)

On Tue, Nov 17, 2015 at 4:33 PM, Leif Hedstrom <zw...@apache.org> wrote:

>
> > On Nov 17, 2015, at 3:11 PM, Nick Kew <ni...@apache.org> wrote:
> >
> > On Tue, 17 Nov 2015 10:29:17 -0800
> > Leif Hedstrom <zw...@apache.org> wrote:
> >
> >> Hi all,
> >>
> >> we have a proposal that all code commits going forward goes through a
> step of Github pull requests.
> >
> > I'm happy with that in principle.  Reads like a classic github workflow.
> >
> > But this reads like a decision that's been made and is being passed down.
> > Did I miss on-list discussion leading to it?
>
>
>
> Also, lets consider this thread the discussion thread :).
>
> — Leif
>
>

Re: github pull requests for all code contributions

Posted by Leif Hedstrom <zw...@apache.org>.
> On Nov 17, 2015, at 3:11 PM, Nick Kew <ni...@apache.org> wrote:
> 
> On Tue, 17 Nov 2015 10:29:17 -0800
> Leif Hedstrom <zw...@apache.org> wrote:
> 
>> Hi all,
>> 
>> we have a proposal that all code commits going forward goes through a step of Github pull requests.
> 
> I'm happy with that in principle.  Reads like a classic github workflow.
> 
> But this reads like a decision that's been made and is being passed down.
> Did I miss on-list discussion leading to it?



Also, lets consider this thread the discussion thread :). 

— Leif


Re: github pull requests for all code contributions

Posted by Nick Kew <ni...@apache.org>.
On Tue, 17 Nov 2015 10:29:17 -0800
Leif Hedstrom <zw...@apache.org> wrote:

> Hi all,
> 
> we have a proposal that all code commits going forward goes through a step of Github pull requests.

I'm happy with that in principle.  Reads like a classic github workflow.

But this reads like a decision that's been made and is being passed down.
Did I miss on-list discussion leading to it?


-- 
Nick Kew