You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Andrew Gaul <no...@github.com> on 2018/01/08 07:21:22 UTC
[jclouds/jclouds] Handle "file" and "file/" collision (#1168)
Fixes gaul/s3proxy#240.
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/1168
-- Commit Summary --
* Handle "file" and "file/" collision
-- File Changes --
M apis/filesystem/src/main/java/org/jclouds/filesystem/strategy/internal/FilesystemStorageStrategyImpl.java (7)
M apis/filesystem/src/test/java/org/jclouds/filesystem/strategy/internal/FilesystemStorageStrategyImplTest.java (19)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/1168.patch
https://github.com/jclouds/jclouds/pull/1168.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1168
Re: [jclouds/jclouds] Handle "file" and "file/" collision (#1168)
Posted by Ka-Hing Cheung <no...@github.com>.
kahing approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1168#pullrequestreview-87730136
Re: [jclouds/jclouds] Handle "file" and "file/" collision (#1168)
Posted by Andrew Gaul <no...@github.com>.
@kahing Please review.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1168#issuecomment-355896953
Re: [jclouds/jclouds] Handle "file" and "file/" collision (#1168)
Posted by Ka-Hing Cheung <no...@github.com>.
kahing approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1168#pullrequestreview-87742643
Re: [jclouds/jclouds] Handle "file" and "file/" collision (#1168)
Posted by Andrew Gaul <no...@github.com>.
> what happens when I put key/ and get(key)?
Added a test for this behavior.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1168#issuecomment-356511978
Re: [jclouds/jclouds] Handle "file" and "file/" collision (#1168)
Posted by Ka-Hing Cheung <no...@github.com>.
what happens when I put key/ and get(key)?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1168#issuecomment-356496930