You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/08/12 15:46:46 UTC

[GitHub] [dolphinscheduler] ptyp opened a new pull request #5985: [SQL][Improvement][Dao] SQL optimization - join

ptyp opened a new pull request #5985:
URL: https://github.com/apache/dolphinscheduler/pull/5985


   ## Purpose of the pull request
   
   This pull request is the project of SOC which is mainly about the optimization of SQL.
   It may not be covered in a single pull request completely, so this pr could be considered a sub outcome.
   
   ## Brief change log
   Change some structures of part of SQL


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] github-actions[bot] commented on pull request #5985: [SOC 2021][Improvement][Dao] SQL optimization - join

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on pull request #5985:
URL: https://github.com/apache/dolphinscheduler/pull/5985#issuecomment-999953346


   This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] github-actions[bot] commented on pull request #5985: [SOC 2021][Improvement][Dao] SQL optimization - join

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on pull request #5985:
URL: https://github.com/apache/dolphinscheduler/pull/5985#issuecomment-1003219107


   This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] github-actions[bot] closed pull request #5985: [SOC 2021][Improvement][Dao] SQL optimization - join

Posted by GitBox <gi...@apache.org>.

github-actions[bot] closed pull request #5985:
URL: https://github.com/apache/dolphinscheduler/pull/5985


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] CalvinKirs commented on pull request #5985: [SOC 2021][Improvement][Dao] SQL optimization - join

Posted by GitBox <gi...@apache.org>.

CalvinKirs commented on pull request #5985:
URL: https://github.com/apache/dolphinscheduler/pull/5985#issuecomment-898206531


   please check CI error.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] ruanwenjun commented on a change in pull request #5985: [SOC 2021][Improvement][Dao] SQL optimization - join

Posted by GitBox <gi...@apache.org>.

ruanwenjun commented on a change in pull request #5985:
URL: https://github.com/apache/dolphinscheduler/pull/5985#discussion_r689427242



##########
File path: dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/WorkFlowLineageMapper.xml
##########
@@ -42,7 +42,7 @@
         ptr.process_definition_version
         where pd.project_code = #{projectCode}
         <if test="ids != null and ids.size()>0">
-            and pd.id in
+            and pd.id exists

Review comment:
       Does this SQL faster?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org