You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@metron.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/10/08 01:30:21 UTC

[jira] [Commented] (METRON-492) Run metron_common build check as local_action

    [ https://issues.apache.org/jira/browse/METRON-492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15556877#comment-15556877 ] 

ASF GitHub Bot commented on METRON-492:
---------------------------------------

GitHub user kylerichardson opened a pull request:

    https://github.com/apache/incubator-metron/pull/302

    METRON-492 Run metron_common build check as local_action

    When testing various deployment options, noticed the logic for the metron_common role didn't work as expected. Updated to check for metron jar locally (where the playbook was initiated) and fail when it doesn't exist.
    
    Tested successfully in single node vm.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kylerichardson/incubator-metron METRON-492

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-metron/pull/302.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #302
    
----
commit bb7da9f667d9e87615c1623a543a74d70cdac53a
Author: kylerichardson <ky...@gmail.com>
Date:   2016-10-08T01:21:51Z

    METRON-492 Run metron_common build check as local_action

----


> Run metron_common build check as local_action
> ---------------------------------------------
>
>                 Key: METRON-492
>                 URL: https://issues.apache.org/jira/browse/METRON-492
>             Project: Metron
>          Issue Type: Bug
>            Reporter: Kyle Richardson
>            Priority: Minor
>
> The metron_common role includes a check for whether or not the jars are built based on a relative path to the playbook. This action should run locally where the build is actually performed.
> The logic for checking that the jars exist also requires fixing. Currently, the logic is opposite of what is expected. It is set to fail if the jar exists.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)