You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by svenvogel <gi...@git.apache.org> on 2015/09/25 10:41:23 UTC
[GitHub] cloudstack pull request: Jira: CLOUDSTACK-8812 / CentOS 7
GitHub user svenvogel opened a pull request:
https://github.com/apache/cloudstack/pull/888
Jira: CLOUDSTACK-8812 / CentOS 7
shapeblue upstream 4.5.2 repository - corrected systemd service file
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/svenvogel/cloudstack master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/888.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #888
----
commit 800b0d376d59812bc197cec00f43af0411df7488
Author: Sven Vogel <sv...@kupper-computer.com>
Date: 2015-09-25T08:37:16Z
Update cloud-management.service
commit 82a7e62dd36eaa44988976926fbcca45a9bab54e
Author: Sven Vogel <sv...@kupper-computer.com>
Date: 2015-09-25T08:38:01Z
Update cloud-management.service
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Jira: CLOUDSTACK-8812 / CentOS 7
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/888#issuecomment-147171964
@svenvogel Thanks for getting back to me. As far as I know, there is no such thing as a ShapeBlue release. They provide packages which make it easy to install CloudStack. It is confusing though, pinging @bhaisaab to see if we can make it more generic like we discussed before.
Please remove the `ExecStart` change, as it doesn't work when I make packages from 4.6 branch:
```
cd packaging
./package.sh -d centos7
```
The result I then install and then it fails when starting `cloudstack-management`:
```
-- Unit cloudstack-management.service has begun starting up.
Oct 10 18:41:09 cs1 systemd[3493]: Failed at step EXEC spawning /usr/sbin/cloudstack-management: No such file or directory
-- Subject: Process /usr/sbin/cloudstack-management could not be executed
-- Defined-By: systemd
```
I will let you know how to make it one commit. Will do that when I'm back at my laptop.
CentOS 7 support is greatly improved in CloudStack 4.6 so this should work. If you want, I can see if I can take it from here and make it work as the `sudo` issue may be there and needs to be resolved.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Jira: CLOUDSTACK-8812 / CentOS 7
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/888#discussion_r41700161
--- Diff: packaging/centos7/cloud-management.service ---
@@ -15,22 +15,19 @@
# specific language governing permissions and limitations
# under the License.
-# Systemd unit file for CloudStack Management server
-#
-# clone tomcat service, see /usr/lib/systemd/system/tomcat.service
-
[Unit]
Description=CloudStack Management Server
After=syslog.target network.target
[Service]
Type=forking
-ExecStart=/usr/sbin/tomcat-sysd start
-ExecStop=/usr/sbin/tomcat-sysd stop
+PermissionsStartOnly=true
+ExecStartPre=/usr/bin/systemd-tmpfiles --create
+ExecStart=/usr/sbin/cloudstack-management start
--- End diff --
Why is this changed? In the RPM package this file is non existent so it fails.
```
-- Unit cloudstack-management.service has begun starting up.
Oct 10 18:41:09 cs1 systemd[3493]: Failed at step EXEC spawning /usr/sbin/cloudstack-management: No such file or directory
-- Subject: Process /usr/sbin/cloudstack-management could not be executed
-- Defined-By: systemd
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Jira: CLOUDSTACK-8812 / CentOS 7
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/888
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Jira: CLOUDSTACK-8812 / CentOS 7
Posted by svenvogel <gi...@git.apache.org>.
Github user svenvogel commented on the pull request:
https://github.com/apache/cloudstack/pull/888#issuecomment-147118164
Thirst
I don't know how I change it to one commit in github.
Second
I don't know why shapeblue change this for their version. I asked again which developer work on systemd. Maybe anyone have already an perfect startup script but I don't know. Shapeblue there are developer which work also on cloudstack. I am not a cloudstack dev. You know?
Third
Maybe centos 7 is supported in 4.6.
Fourth
I can change the name.
Mit freundlichen Grüßen
Sven Vogel
---------------------------------------------
Sven Vogel
Systems Engineer / Consultant
Kupper Computer GmbH
Prager Straße 15
04103 Leipzig
Registergericht Leipzig: HRB 19970
Geschäftsführer: Dipl.-Ing. Andreas Kupper
Tel: +49 (0)341 305 36 0
Fax: +49 (0)341 305 36 63
Web: http://www.kupper-computer.com
http://www.kupper-websolutions.de
Mail: mailto:sven.vogel@kupper-computer.com
Von: Remi Bergsma
Gesendet: Samstag, 10. Oktober 2015 19:33
An: apache/cloudstack
Antwort an: apache/cloudstack
Cc: Vogel, Sven
Betreff: Re: [cloudstack] Jira: CLOUDSTACK-8812 / CentOS 7 (#888)
@svenvogel<https://github.com/svenvogel> Please update the title to something like this: "CLOUDSTACK-8812 Fix CentOS 7 systemd-tmpfiles - Operation not permitted" as it is more descriptive.
—
Reply to this email directly or view it on GitHub<https://github.com/apache/cloudstack/pull/888#issuecomment-147111646>.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Jira: CLOUDSTACK-8812 / CentOS 7
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/888#discussion_r42110792
--- Diff: packaging/centos7/cloud-management.service ---
@@ -15,22 +15,19 @@
# specific language governing permissions and limitations
# under the License.
-# Systemd unit file for CloudStack Management server
-#
-# clone tomcat service, see /usr/lib/systemd/system/tomcat.service
-
[Unit]
Description=CloudStack Management Server
After=syslog.target network.target
[Service]
Type=forking
-ExecStart=/usr/sbin/tomcat-sysd start
-ExecStop=/usr/sbin/tomcat-sysd stop
+PermissionsStartOnly=true
+ExecStartPre=/usr/bin/systemd-tmpfiles --create
+ExecStart=/usr/sbin/cloudstack-management start
--- End diff --
I see a similar change in 4.5:packaging/centos63/rhel7/cloud-management.service
```
[Service]
Type=forking
ExecStartPre=/usr/bin/systemd-tmpfiles --create
ExecStart=/usr/sbin/cloudstack-management start
ExecStop=/usr/sbin/cloudstack-management stop
SuccessExitStatus=143
User=cloud
Group=cloud
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Jira: CLOUDSTACK-8812 / CentOS 7
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/888#issuecomment-147111646
@svenvogel Please update the title to something like this: "CLOUDSTACK-8812 Fix CentOS 7 systemd-tmpfiles - Operation not permitted" as it is more descriptive.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Jira: CLOUDSTACK-8812 / CentOS 7
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/888#issuecomment-147090137
LGTM, please merge once tested. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Jira: CLOUDSTACK-8812 / CentOS 7
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/888#issuecomment-143589136
Hi @svenvogel Thanks! Can you please squash the 2 commits into 1 and also rebase with current master (make sure you have just one commit)? Then we'll be able to test it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Jira: CLOUDSTACK-8812 / CentOS 7
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/888#issuecomment-147111458
@svenvogel Something went wrong with the squashing as you now have 4 commits for this change. Can you make it a single commit please? Let me know if you need help.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Jira: CLOUDSTACK-8812 / CentOS 7
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/888#issuecomment-147090129
Wait, I don't remember but did n't I merge this on master? I'm sure it is in 4.5. (sorry, in case I missed this fix).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---