[jira] [Updated] (HDDS-10090) Clean up TestStorageContainerManager

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HDDS-10090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ASF GitHub Bot updated HDDS-10090:
----------------------------------
    Labels: GoodForNewContributors pull-request-available  (was: GoodForNewContributors)

> Clean up TestStorageContainerManager
> ------------------------------------
>
>                 Key: HDDS-10090
>                 URL: https://issues.apache.org/jira/browse/HDDS-10090
>             Project: Apache Ozone
>          Issue Type: Sub-task
>          Components: test
>            Reporter: Attila Doroszlai
>            Assignee: Will Xiao
>            Priority: Minor
>              Labels: GoodForNewContributors, pull-request-available
>
> {{TestStorageContainerManager}} has some items to be cleaned up:
>  * Disabled test cases related to non-HA to HA change.  This used to be not supported scenario, but was recently implemented in HDDS-9897.  Since that task also added a new test case, {{testSCMReinitializationWithHAEnabled}} and {{testSCMReinitializationWithHAUpgrade}} can be removed now.
>  * Test cases can now use {{MiniOzoneCluster}} wrapped in {{try-with-resources}} blocks to ensure the cluster is shut down even if {{waitForClusterToBeReady()}} and other operations fail.
>  * {{Thread.currentThread().sleep()}} can be replaced with {{Thread.sleep()}}.
>  * Convert {{try-catch}} blocks to {{assertThrows()}} where applicable (where exception is expected and {{try}} block calls {{fail()}}.
>  * Replace usage of {{GenericTestUtils.getTempPath}} with {{@TempDir}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org