You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2019/10/24 15:16:00 UTC

[jira] [Commented] (GEODE-5194) Relax Gfsh version checking on connect, allow connecting to different patch versions

    [ https://issues.apache.org/jira/browse/GEODE-5194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16958965#comment-16958965 ] 

ASF subversion and git services commented on GEODE-5194:
--------------------------------------------------------

Commit 113b2006ee885211a1bbfc5510b65625a94f2fbc in geode's branch refs/heads/develop from Owen Nichols
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=113b200 ]

GEODE-5194: allow gfsh to connect if serialization version matches (#4202)

* GEODE-5194: allow gfsh to connect if serialization version matches

This builds on the previous work that relaxed the version check to
ignore patch version changes.  Now even differing minor versions may be
compatible (i.e. no changes to gfsh commands or options).  Serialization
version is not a perfect proxy for when gfsh commands have changed, but
this is at least an improvement over the previous check...

Co-authored-by: Jinmei Liao <ji...@pivotal.io>

* empty

* rename geodeVersion to geodeSerializationVersion to more accurately reflect what it represents


> Relax Gfsh version checking on connect, allow connecting to different patch versions
> ------------------------------------------------------------------------------------
>
>                 Key: GEODE-5194
>                 URL: https://issues.apache.org/jira/browse/GEODE-5194
>             Project: Geode
>          Issue Type: Improvement
>          Components: gfsh
>            Reporter: Ken Howe
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.7.0
>
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> Currently Gfsh, {{connect}} command will only connect to locator with the same exact version. Patch versions should not add or change functionality of commands, so for Gfsh version {{x.y.z}} connection to locator with same major and minor, {{x.y}}, version with a different patch, {{.z}}, should be allowed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)