[jira] [Commented] (CLOUDSTACK-8601) VMFS storage added as local storage can be re added as shared storage.

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14661289#comment-14661289 ] 

ASF GitHub Bot commented on CLOUDSTACK-8601:
--------------------------------------------

Github user mike-tutkowski commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/547#discussion_r36490233
  
    --- Diff: core/src/com/cloud/agent/api/ModifyStoragePoolAnswer.java ---
    @@ -26,6 +26,7 @@
     public class ModifyStoragePoolAnswer extends Answer {
         StoragePoolInfo poolInfo;
         Map<String, TemplateProp> templateInfo;
    +    String localDatastoreName = null;
    --- End diff --
    
    I recommend that all three of these member variables be made private.


> VMFS storage added as local storage can be re added as shared storage.
> ----------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-8601
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8601
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Likitha Shetty
>            Assignee: Likitha Shetty
>             Fix For: 4.6.0
>
>
> During host discovery, if local storage is enabled for a zone, all VMFS datastores that are mounted on just one host (i.e. not shared) will be added as local storage is CloudStack.
> When admin adds a VMFS datastore as shared, CS doesn't verify if the storage has already been added as local storage in the zone. This means the same primary storage is added as different storages in CS and this leads to failure in operations related to disks because of wrong storage look ups.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)