[GitHub] [superset] villebro commented on pull request #12946: feat(native-filters): Add time filters

[GitBox <gi...@apache.org>]

villebro commented on pull request #12946:
URL: https://github.com/apache/superset/pull/12946#issuecomment-773916360


   > Currently the time range filter in FilterBox is not tied to any datasource. It will apply to any chart that is in scope and has a time column specified, regardless if it's using the same datasource or not.
   > 
   > The new [time filter in native filters](https://github.com/apache/superset/pull/12946) seems to be tied to a specific datasource and field, I'm wondering how this time filter will actually work in the dashboard?
   > 
   > Will it work like the old Time Range filter in `FilterBox`, or will it work on the selected `ds` column on the selected datasource?
   
   This will be changed shortly - the time filter won't be tied to a datasource, and will only have the time picker (no need for datasource, column etc). Also, the date column filter will be ported to native filters, and that one will obviously have a datasource.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org