You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/10/04 15:35:48 UTC
[GitHub] TisonKun commented on a change in pull request #6729: [FLINK-10386]
[taskmanager] Remove legacy class TaskExecutionStateListener
TisonKun commented on a change in pull request #6729: [FLINK-10386] [taskmanager] Remove legacy class TaskExecutionStateListener
URL: https://github.com/apache/flink/pull/6729#discussion_r222720265
##########
File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamTaskTest.java
##########
@@ -846,6 +817,23 @@ public void testSetsUserCodeClassLoaderForTimerThreadFactory() throws Throwable
// Test Utilities
// ------------------------------------------------------------------------
+ private static void waitUntilExecutionState(Task task, ExecutionState exceptedState, Deadline deadline) {
+ while (deadline.hasTimeLeft()) {
+ if (exceptedState == task.getExecutionState()) {
+ return;
+ }
+
+ try {
+ Thread.sleep(Math.min(deadline.timeLeft().toMillis(), 200));
Review comment:
@tillrohrmann yes it has been addressed, please see the following commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services