You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2016/04/18 18:39:04 UTC
[GitHub] flink pull request: [FLINK-3778] [shell] Forward configuration fro...
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/1906
[FLINK-3778] [shell] Forward configuration from FlinkILoop to ScalaShellRemoteStreamEnvironment
Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful description of your changes.
- [X] General
- The pull request references the related JIRA issue
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message
- [X] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [X] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis build has passed
With this PR the configuration of the FlinkILoop is properly forwarded to the
ScalaShellRemoteStreamEnvironment.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink fixScalaShellStream
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1906.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1906
----
commit 22d710a17003863a347546f248f35a609cbf6c91
Author: Till Rohrmann <tr...@apache.org>
Date: 2016-04-18T16:34:55Z
[FLINK-3778] [shell] Forward configuration from FlinkILoop to ScalaShellRemoteStreamEnvironment
With this PR the configuration of the FlinkILoop is properly forwarded to the
ScalaShellRemoteStreamEnvironment.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3778] [shell] Forward configuration fro...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1906#discussion_r60187361
--- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/RemoteStreamEnvironment.java ---
@@ -90,7 +90,7 @@ public RemoteStreamEnvironment(String host, int port, String... jarFiles) {
* @param port
* The port of the master (JobManager), where the program should
* be executed.
- * @param config
+ * @param clientConfiguration
--- End diff --
I like the renaming, makes it clearer 👍
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3778] [shell] Forward configuration fro...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1906#issuecomment-211783962
Changes look good to me. +1 to merge (I did not try it out though).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3778] [shell] Forward configuration fro...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1906
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3778] [shell] Forward configuration fro...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1906#discussion_r60187290
--- Diff: flink-scala-shell/src/main/scala/org/apache/flink/api/scala/FlinkILoop.scala ---
@@ -72,7 +72,12 @@ class FlinkILoop(
// create our environment that submits against the cluster (local or remote)
val remoteBenv = new ScalaShellRemoteEnvironment(host, port, this, clientConfig)
- val remoteSenv = new ScalaShellRemoteStreamEnvironment(host, port, this);
+ val remoteSenv = new ScalaShellRemoteStreamEnvironment(
+ host,
+ port,
+ this,
+ clientConfig,
+ getExternalJars(): _*);
--- End diff --
Wow, never seen `: _*` before :smile:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3778] [shell] Forward configuration fro...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1906#issuecomment-214406242
Failing test cases are unrelated. Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---