[GitHub] [iceberg] RussellSpitzer commented on a change in pull request #1433: Fix the bug that clientPool#close will block forever when newClient encountered an exception.

[GitBox <gi...@apache.org>]

RussellSpitzer commented on a change in pull request #1433:
URL: https://github.com/apache/iceberg/pull/1433#discussion_r484982190



##########
File path: hive-metastore/src/main/java/org/apache/iceberg/hive/ClientPool.java
##########
@@ -114,8 +114,9 @@ private C get() throws InterruptedException {
           if (!clients.isEmpty()) {
             return clients.removeFirst();
           } else if (currentSize < poolSize) {
+            C client = newClient();
             currentSize += 1;

Review comment:
       This is real issue here right? We have the possibility of incrementing current size even if "newClient" failed in the old code? If so this seems like the right fix to me




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org