[GitHub] [kafka] nizhikov commented on a change in pull request #9196: [WIP] KAFKA-10402: Upgrade system tests to python3

[GitBox <gi...@apache.org>]

nizhikov commented on a change in pull request #9196:
URL: https://github.com/apache/kafka/pull/9196#discussion_r475188280



##########
File path: tests/kafkatest/tests/streams/streams_broker_bounce_test.py
##########
@@ -119,7 +119,7 @@ def __init__(self, test_context):
     def fail_broker_type(self, failure_mode, broker_type):
         # Pick a random topic and bounce it's leader
         topic_index = randint(0, len(self.topics.keys()) - 1)
-        topic = self.topics.keys()[topic_index]
+        topic = [*self.topics.keys()][topic_index]

Review comment:
       fixed.

##########
File path: tests/kafkatest/tests/verifiable_consumer_test.py
##########
@@ -40,7 +40,7 @@ def _all_partitions(self, topic, num_partitions):
 
     def _partitions(self, assignment):
         partitions = []
-        for parts in assignment.itervalues():
+        for parts in iter(assignment.values()):

Review comment:
       fixed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org