[jira] Closed: (DOXIA-370) Confluence module cannot parse horizontal separator

["Lukas Theussl (JIRA)" <ji...@codehaus.org>]

     [ http://jira.codehaus.org/browse/DOXIA-370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lukas Theussl closed DOXIA-370.
-------------------------------

       Resolution: Fixed
    Fix Version/s: 1.1.3
         Assignee: Lukas Theussl

Patch applied in [r947266|http://svn.apache.org/viewvc?view=revision&revision=947266]. Thanks!

> Confluence module cannot parse horizontal separator
> ---------------------------------------------------
>
>                 Key: DOXIA-370
>                 URL: http://jira.codehaus.org/browse/DOXIA-370
>             Project: Maven Doxia
>          Issue Type: Bug
>          Components: Module - Confluence
>    Affects Versions: 1.1.1
>            Reporter: Dave Syer
>            Assignee: Lukas Theussl
>             Fix For: 1.1.3
>
>         Attachments: DOXIA-370.patch
>
>
> Confluence module cannot parse horizontal separator.  E.g. if you parse this
> {code}
> Up
> ----
> Down
> {code}
> you get out of bounds exception in the ListBlockParser.  This code looks pretty flakey (I probably wrote it, so apologies if it was my fault):
> {code}
>    private boolean isList( String line )
>     {
>         line = line.trim();
>         if ( line.startsWith( "*" ) || line.startsWith( "-" ) || line.startsWith( "#" ) )
>         {
>             String temp = line.substring( 1 );
>             while ( temp.charAt( 0 ) == '*' || temp.charAt( 0 ) == '-' || temp.charAt( 0 ) == '#' )
>             {
>                 temp = temp.substring( 1 );
>             }
>             if ( temp.charAt( 0 ) == ' ' )
>             {
>                 return true;
>             }
>         }
>         return false;
>     }
> {code}
> There are a load of potential out of bounds exceptions there.   This one happens to come from the fact that the loop never terminates before the temp string is exhausted.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira