[GitHub] [incubator-superset] betodealmeida opened a new pull request #7540: A few improvements to scheduling queries

[GitBox <gi...@apache.org>]

betodealmeida opened a new pull request #7540: A few improvements to scheduling queries
URL: https://github.com/apache/incubator-superset/pull/7540
 
 
   ### CATEGORY
   
   Choose one
   
   - [ ] Bug Fix
   - [X] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   This PR improves the UI/UX when scheduling queries:
   
   - The message now says "Your query has been scheduled. To see details of your query, navigate to Saved Queries". Before we were hijacking the save dialog that simply said "Your query has been saved."
   - The UI only allows queries to be scheduled after they've run successfully once. The user still can edit the query after (to insert a `ds` macro, eg) and schedule it.
   - The UI now prompts for the query name and a description.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ![lp_improv](https://user-images.githubusercontent.com/1534870/57945004-8f375200-788d-11e9-863c-b4b4b4715213.gif)
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   Tested locally.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   
   @khtruong @datability-io @DiggidyDave @xtinec 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org