[GitHub] [doris] zhangstar333 commented on a diff in pull request #10296: [vectorized][udf] improvement java-udaf with group by clause

[GitBox <gi...@apache.org>]

zhangstar333 commented on code in PR #10296:
URL: https://github.com/apache/doris/pull/10296#discussion_r918871188


##########
be/src/vec/aggregate_functions/aggregate_function_java_udaf.h:
##########
@@ -96,6 +98,7 @@ struct AggregateJavaUdafData {
             ctor_params.__set_input_buffer_ptrs((int64_t)input_values_buffer_ptr.get());
             ctor_params.__set_input_nulls_ptrs((int64_t)input_nulls_buffer_ptr.get());
             ctor_params.__set_output_buffer_ptr((int64_t)output_value_buffer.get());
+            ctor_params.__set_input_places_ptr((int64_t)input_place_ptrs.get());

Review Comment:
   OK, will be refactor this in next PR



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org