[GitHub] [helix] xyuanlu commented on a change in pull request #1852: Disable delayed rebalance as default for partitionAssignment

[GitBox <gi...@apache.org>]

xyuanlu commented on a change in pull request #1852:
URL: https://github.com/apache/helix/pull/1852#discussion_r698078593



##########
File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/ResourceAssignmentOptimizerAccessor.java
##########
@@ -220,7 +220,14 @@ private ClusterState readClusterStateAndValidateInput(String clusterId, InputFie
       }
     }
 
-    clusterState.clusterConfig = cfgAccessor.getClusterConfig(clusterId);
+    // We will not consider delayed rebalance. The current implementation of
+    // 'getIdealAssignmentForFullAuto' for ChrushEd resources will not consider delayed rebalancer
+    // but `getImmediateAssignmentForWagedFullAuto` will honor current timestamp and delayed
+    // rebalance window. We are disabling delayed rebalance for now. Could add a cluster option to
+    // honor delayed rebalance window in the future.
+    ClusterConfig clusterConfig = cfgAccessor.getClusterConfig(clusterId);
+    clusterConfig.setDelayRebalaceEnabled(false);

Review comment:
       TFTR. Updated. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org