You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hop.apache.org by "hansva (via GitHub)" <gi...@apache.org> on 2026/10/16 07:52:25 UTC
[PR] data format mask is not inherited correctly, fixes #8956 (hop)
hansva opened a new pull request, #8959:
URL: https://github.com/apache/hop/pull/8959
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`.
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable.
To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] data format mask is not inherited correctly, fixes #8956 (hop)
Posted by "bamaer (via GitHub)" <gi...@apache.org>.
bamaer commented on PR #8959:
URL: https://github.com/apache/hop/pull/8959#issuecomment-6215246600
@hansva LGTM.
Verified locally:
- `TextFileOutputFormatInheritanceTest` fails without the fix (`expected: <dd-MM-yyyy> but was: <>`) and passes with it; the textfile module's tests all pass.
- `main-0123-text-file-output-inherited-formats` passes with the PR. Against the pre-fix jar it fails on `d_input`, `d_select` and `n_input` (written as `2024/05/17 00:00:00.000` and `42`).
- `main-0108-data-set-output` still passes with the dataset moved to `output/`.
I also looked for other `!= null` guards in front of mask/symbol setters; this was the only one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] data format mask is not inherited correctly, fixes #8956 (hop)
Posted by "bamaer (via GitHub)" <gi...@apache.org>.
bamaer merged PR #8959:
URL: https://github.com/apache/hop/pull/8959
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org