You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2019/03/22 12:44:00 UTC
[GitHub] [mynewt-core] utzig commented on a change in pull request #1716:
net/oic; if resource handler fails a request, don't honor observer option.
utzig commented on a change in pull request #1716: net/oic; if resource handler fails a request, don't honor observer option.
URL: https://github.com/apache/mynewt-core/pull/1716#discussion_r268151176
##########
File path: net/oic/src/api/oc_ri.c
##########
@@ -587,6 +586,8 @@ oc_ri_invoke_coap_entity_handler(struct coap_packet_rx *request,
response_buffer.response_length = 0;
response_buffer.code = oc_status_code(OC_STATUS_FORBIDDEN);
success = false;
+ } else if (response_buffer.code >= BAD_REQUEST_4_00) {
Review comment:
I think it would be more idiomatic by writing `response_buffer.code >= oc_status_code(OC_STATUS_BAD_REQUEST)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services