You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2023/02/06 08:19:03 UTC
[GitHub] [arrow] kou opened a new pull request, #34048: GH-32292: [R][Packaging] Use binaries build on CentOS 7 for Ubuntu < 22.04
kou opened a new pull request, #34048:
URL: https://github.com/apache/arrow/pull/34048
### Rationale for this change
Binaries build on CentOS 7 uses `_GLIBCXX_USE_CXX11_ABI=0`. So we can't use them on Ubuntu 20.04 because
Ubuntu 20.04 uses `_GLIBCXX_USE_CXX11_ABI=1`. If we use them on Ubuntu 20.04, our R package must use
`_GLIBCXX_USE_CXX11_ABI=0` too.
### What changes are included in this PR?
This changes add `-D_GLIBCXX_USE_CXX11_ABI=0` to `Cflags` in `arrow.pc`. Our R package uses `Cflags` in
`arrow.pc`. So users don't need to specify `-D_GLIBCXX_USE_CXX11_ABI=0` explicitly.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
* Closes GH-33091
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on a diff in pull request #34048: GH-32292: [R][Packaging] Use binaries build on CentOS 7 for Ubuntu < 22.04
Posted by "nealrichardson (via GitHub)" <gi...@apache.org>.
nealrichardson commented on code in PR #34048:
URL: https://github.com/apache/arrow/pull/34048#discussion_r1097550745
##########
ci/scripts/r_install_system_dependencies.sh:
##########
@@ -37,10 +37,10 @@ if [ "$ARROW_S3" == "ON" ] || [ "$ARROW_GCS" == "ON" ] || [ "$ARROW_R_DEV" == "T
# Install curl and OpenSSL for S3/GCS support
case "$PACKAGE_MANAGER" in
apt-get)
- apt-get install -y libcurl4-openssl-dev libssl-dev
+ apt-get install -y libcurl4-openssl-dev libssl-dev pkg-config
Review Comment:
How common is it to be on ubuntu and not have pkg-config installed? Does this mean we would require pkg-config in order for the binary to be used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #34048: GH-32292: [R][Packaging] Use binaries build on CentOS 7 for Ubuntu < 22.04
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #34048:
URL: https://github.com/apache/arrow/pull/34048#issuecomment-1420449188
We can't use the `centos-7` binary on Ubuntu 20.04 because `centos-7` binary built with OpenSSL 1.0 and Ubuntu 20.04 uses OpenSSL 1.1.
https://github.com/ursacomputing/crossbow/actions/runs/4103886242/jobs/7078891973#step:12:266
> ```text
> /opt/R/4.1.3/lib/R/library/00LOCK-arrow/00new/arrow/libs/arrow.so: undefined symbol: HMAC_CTX_cleanup
> ```
FYI: `HMAC_CTX_cleanup()` is referred by aws-sdk-cpp.
Here are solution candidates:
1. Add `centos-7-openssl-1.1` binary (We can use OpenSSL 1.1 on CentOS 7 because EPEL provides `openssl11-devel)
2. Add `ubuntu-20.04` binary
3. Updating aws-sdk-cpp (#33808) may resolve this because OpenSSL related code is changed in the latest aws-sdk-cpp (hint: s2n-tls)
I'll try 3. first but is there any preference?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34048: GH-32292: [R][Packaging] Use binaries build on CentOS 7 for Ubuntu < 22.04
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34048:
URL: https://github.com/apache/arrow/pull/34048#issuecomment-1423732447
Revision: 414260122155109b35d5227c77e92ed520250892
Submitted crossbow builds: [ursacomputing/crossbow @ actions-27147bef43](https://github.com/ursacomputing/crossbow/branches/all?query=actions-27147bef43)
|Task|Status|
|----|------|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/4131813145/jobs/7139827663)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #34048: GH-32292: [R][Packaging] Use binaries build on CentOS 7 for Ubuntu < 22.04
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #34048:
URL: https://github.com/apache/arrow/pull/34048#issuecomment-1418989746
@github-actions crossbow submit r-binary-packages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on pull request #34048: GH-32292: [R][Packaging] Use binaries built on CentOS 7 for Ubuntu < 22.04
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on PR #34048:
URL: https://github.com/apache/arrow/pull/34048#issuecomment-1478879195
(I merged now so it the change affects the next packaging-nightly run)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34048: GH-32292: [R][Packaging] Use binaries built on CentOS 7 for Ubuntu < 22.04
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34048:
URL: https://github.com/apache/arrow/pull/34048#issuecomment-1474917967
Revision: a07787040134163cd9bd99dde5017479415ee618
Submitted crossbow builds: [ursacomputing/crossbow @ actions-4538096eaa](https://github.com/ursacomputing/crossbow/branches/all?query=actions-4538096eaa)
|Task|Status|
|----|------|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/4456454060/jobs/7826919568)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34048: GH-32292: [R][Packaging] Use binaries built on CentOS 7 for Ubuntu < 22.04
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34048:
URL: https://github.com/apache/arrow/pull/34048#issuecomment-1474863759
Revision: 5fba7e0697bb0ef6214fc25427c5ce01432d736c
Submitted crossbow builds: [ursacomputing/crossbow @ actions-120bc3c0cc](https://github.com/ursacomputing/crossbow/branches/all?query=actions-120bc3c0cc)
|Task|Status|
|----|------|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/4455795558/jobs/7825833042)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on a diff in pull request #34048: GH-32292: [R][Packaging] Use binaries build on CentOS 7 for Ubuntu < 22.04
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on code in PR #34048:
URL: https://github.com/apache/arrow/pull/34048#discussion_r1097664874
##########
cpp/src/arrow/CMakeLists.txt:
##########
@@ -576,6 +576,19 @@ if(ARROW_BUILD_BUNDLED_DEPENDENCIES)
string(APPEND ARROW_PC_LIBS_PRIVATE " -larrow_bundled_dependencies")
list(INSERT ARROW_STATIC_INSTALL_INTERFACE_LIBS 0 "Arrow::arrow_bundled_dependencies")
endif()
+
+if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
+ set(GLIBCXX_USE_CXX11_ABI_SOURCE
+ ${CMAKE_CURRENT_BINARY_DIR}/try_compile_glibcxx_use_cxx_abi.cc)
+ file(WRITE ${GLIBCXX_USE_CXX11_ABI_SOURCE} "#if !_GLIBCXX_USE_CXX11_ABI\n"
+ "#error Not using CXX11 ABI\n" "#endif\n")
+ try_compile(IS_GLIBCXX_USE_CXX11_ABI ${CMAKE_CURRENT_BINARY_DIR}/try_compile
+ SOURCES ${GLIBCXX_USE_CXX11_ABI_SOURCE})
+ if(NOT IS_GLIBCXX_USE_CXX11_ABI)
+ string(APPEND ARROW_PC_CFLAGS " -D_GLIBCXX_USE_CXX11_ABI=0")
+ endif()
+endif()
Review Comment:
Ah I see, thanks for the explanation!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #34048: GH-32292: [R][Packaging] Use binaries build on CentOS 7 for Ubuntu < 22.04
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #34048:
URL: https://github.com/apache/arrow/pull/34048#discussion_r1101043112
##########
ci/scripts/r_install_system_dependencies.sh:
##########
@@ -37,10 +37,10 @@ if [ "$ARROW_S3" == "ON" ] || [ "$ARROW_GCS" == "ON" ] || [ "$ARROW_R_DEV" == "T
# Install curl and OpenSSL for S3/GCS support
case "$PACKAGE_MANAGER" in
apt-get)
- apt-get install -y libcurl4-openssl-dev libssl-dev
+ apt-get install -y libcurl4-openssl-dev libssl-dev pkg-config
Review Comment:
> I'd rather ship a binary that just works. Would it be terrible to grep for the CXX11_ABI in arrow.pc and add it to `PKG_CFLAGS`?
It will work. I've added the logic but I'm afraid of increasing ad-hoc logics again.
> If we were to set `LIBARROW_BINARY=false` if no pkg-config, it should be in its own `"${PKG_CONFIG_AVAILABLE}" = "false"` check, not connected to whatever the value of `ARROW_DEPENDENCY_SOURCE` is since that's about building libarrow from source.
It makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #34048: GH-32292: [R][Packaging] Use binaries built on CentOS 7 for Ubuntu < 22.04
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #34048:
URL: https://github.com/apache/arrow/pull/34048#issuecomment-1474862946
@github-actions crossbow submit r-binary-packages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #34048: GH-32292: [R][Packaging] Use binaries built on CentOS 7 for Ubuntu < 22.04
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #34048:
URL: https://github.com/apache/arrow/pull/34048#issuecomment-1477989237
@github-actions crossbow submit -g cpp r-binary-packages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34048: GH-32292: [R][Packaging] Use binaries built on CentOS 7 for Ubuntu < 22.04
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34048:
URL: https://github.com/apache/arrow/pull/34048#issuecomment-1475053841
Revision: 2f8b11d2c93b777883ff1214e4fd5bc2ee7e6367
Submitted crossbow builds: [ursacomputing/crossbow @ actions-8edbbb8e7a](https://github.com/ursacomputing/crossbow/branches/all?query=actions-8edbbb8e7a)
|Task|Status|
|----|------|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/4458132106/jobs/7829683979)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #34048: GH-32292: [R][Packaging] Use binaries build on CentOS 7 for Ubuntu < 22.04
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #34048:
URL: https://github.com/apache/arrow/pull/34048#issuecomment-1423730032
@github-actions crossbow submit r-binary-packages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34048: GH-32292: [R][Packaging] Use binaries built on CentOS 7 for Ubuntu < 22.04
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34048:
URL: https://github.com/apache/arrow/pull/34048#issuecomment-1478659282
Revision: 955aa34cbe395f266c4a4de5e833d880436256b0
Submitted crossbow builds: [ursacomputing/crossbow @ actions-0f2d95fc8a](https://github.com/ursacomputing/crossbow/branches/all?query=actions-0f2d95fc8a)
|Task|Status|
|----|------|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/4484293606/jobs/7884647050)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #34048: GH-32292: [R][Packaging] Use binaries built on CentOS 7 for Ubuntu < 22.04
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #34048:
URL: https://github.com/apache/arrow/pull/34048#issuecomment-1475406425
@github-actions crossbow submit r-binary-packages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #34048: GH-32292: [R][Packaging] Use binaries built on CentOS 7 for Ubuntu < 22.04
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #34048:
URL: https://github.com/apache/arrow/pull/34048#issuecomment-1475083570
@github-actions crossbow submit r-binary-packages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34048: GH-32292: [R][Packaging] Use binaries built on CentOS 7 for Ubuntu < 22.04
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34048:
URL: https://github.com/apache/arrow/pull/34048#issuecomment-1477933394
```
Failed to render template `r/github.packages.yml` with UndefinedError: 'id' is undefined
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/4480168908
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34048: GH-32292: [R][Packaging] Use binaries built on CentOS 7 for Ubuntu < 22.04
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34048:
URL: https://github.com/apache/arrow/pull/34048#issuecomment-1475392192
Revision: cb6ef66b6a21e15e4f00142f8a1895fd22974098
Submitted crossbow builds: [ursacomputing/crossbow @ actions-6dc5155344](https://github.com/ursacomputing/crossbow/branches/all?query=actions-6dc5155344)
|Task|Status|
|----|------|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/4462614132/jobs/7837276900)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34048: GH-32292: [R][Packaging] Use binaries build on CentOS 7 for Ubuntu < 22.04
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34048:
URL: https://github.com/apache/arrow/pull/34048#issuecomment-1419046270
Revision: 0b8afc62dd55c18b285e7ff814c6c4baac5fde82
Submitted crossbow builds: [ursacomputing/crossbow @ actions-5584623de7](https://github.com/ursacomputing/crossbow/branches/all?query=actions-5584623de7)
|Task|Status|
|----|------|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/4103886242/jobs/7078661530)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #34048: GH-32292: [R][Packaging] Use binaries build on CentOS 7 for Ubuntu < 22.04
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #34048:
URL: https://github.com/apache/arrow/pull/34048#issuecomment-1423724786
Upgrading aws-sdk-cpp doesn't solve the problem.
> Could we bundle openssl rather than require it from the system? I think the answer from last time I asked this was "no because security", but also as I understand it, the python wheels include openssl in them.
Hmm. I want to stop bundling OpenSSL in wheel because we can't release a fixed version in a timely manner for now.
For example, we released 10.0.1 for https://nvd.nist.gov/vuln/detail/CVE-2022-3786 .
CVE-2022-3786 was published on 2022-11-01,
the 10.0.1 vote https://lists.apache.org/thread/rlkrj9lnfmwgn7kq8hvmzf06l5z6w30k was started on 2022-11-17 and
the vote was carried on 2022-11-23 https://lists.apache.org/thread/ozo2k7l7jhc0wj3wsrpqgsvy4fosprv8 .
Anyway, I try bundling OpenSSL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34048: GH-32292: [R][Packaging] Use binaries built on CentOS 7 for Ubuntu < 22.04
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34048:
URL: https://github.com/apache/arrow/pull/34048#issuecomment-1475025757
Revision: 3ef50670bcd2c5463cc249dd1fb9dd8b819a567b
Submitted crossbow builds: [ursacomputing/crossbow @ actions-d6e212e96f](https://github.com/ursacomputing/crossbow/branches/all?query=actions-d6e212e96f)
|Task|Status|
|----|------|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/4457736192/jobs/7828989310)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #34048: GH-32292: [R][Packaging] Use binaries build on CentOS 7 for Ubuntu < 22.04
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #34048:
URL: https://github.com/apache/arrow/pull/34048#issuecomment-1418682321
@github-actions crossbow submit r-binary-packages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #34048: GH-32292: [R][Packaging] Use binaries build on CentOS 7 for Ubuntu < 22.04
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #34048:
URL: https://github.com/apache/arrow/pull/34048#issuecomment-1419042810
@github-actions crossbow submit r-binary-packages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #34048: GH-32292: [R][Packaging] Use binaries build on CentOS 7 for Ubuntu < 22.04
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #34048:
URL: https://github.com/apache/arrow/pull/34048#issuecomment-1425216655
We can't use static linking for OpenSSL:
https://github.com/ursacomputing/crossbow/actions/runs/4140935566/jobs/7160057196#step:6:1857
```text
/arrow/r/libarrow/dist/s2n_tls_ep-prefix/src/s2n_tls_ep/crypto/s2n_fips.c:21:6: error: #error "Interning with OpenSSL fips-validated libcrypto is not currently supported. See https://github.com/aws/s2n-tls/issues/2741"
#error "Interning with OpenSSL fips-validated libcrypto is not currently supported. See https://github.com/aws/s2n-tls/issues/2741"
^~~~~
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #34048: GH-32292: [R][Packaging] Use binaries built on CentOS 7 for Ubuntu < 22.04
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #34048:
URL: https://github.com/apache/arrow/pull/34048#issuecomment-1474915591
@github-actions crossbow submit r-binary-packages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on a diff in pull request #34048: GH-32292: [R][Packaging] Use binaries built on CentOS 7 for Ubuntu < 22.04
Posted by "nealrichardson (via GitHub)" <gi...@apache.org>.
nealrichardson commented on code in PR #34048:
URL: https://github.com/apache/arrow/pull/34048#discussion_r1142831623
##########
r/tools/nixlibs.R:
##########
@@ -99,8 +99,8 @@ download_binary <- function(lib) {
# * Some other string: a "distro-version" that corresponds to a binary that is
# available, to override what this function may discover by default.
# Possible values are:
-# * "centos-7" (gcc 8 (devtoolset), openssl 1, glib 2.17)
-# * "ubuntu-18.04" (gcc 8, openssl 1, glib 2.27)
+# * "centos-7" (gcc 8 (devtoolset), _GLIBCXX_USE_CXX11_ABI=0, openssl 1.0)
Review Comment:
Feel free to rename any of these. The OS is not relevant like it used to be, so calling them centos or ubuntu anything is misleading.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #34048: GH-32292: [R][Packaging] Use binaries built on CentOS 7 for Ubuntu < 22.04
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #34048:
URL: https://github.com/apache/arrow/pull/34048#issuecomment-1477930557
@github-actions crossbow submit -g cpp r-binary-packages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #34048: GH-32292: [R][Packaging] Use binaries build on CentOS 7 for Ubuntu < 22.04
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #34048:
URL: https://github.com/apache/arrow/pull/34048#discussion_r1097302416
##########
cpp/src/arrow/CMakeLists.txt:
##########
@@ -576,6 +576,19 @@ if(ARROW_BUILD_BUNDLED_DEPENDENCIES)
string(APPEND ARROW_PC_LIBS_PRIVATE " -larrow_bundled_dependencies")
list(INSERT ARROW_STATIC_INSTALL_INTERFACE_LIBS 0 "Arrow::arrow_bundled_dependencies")
endif()
+
+if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
+ set(GLIBCXX_USE_CXX11_ABI_SOURCE
+ ${CMAKE_CURRENT_BINARY_DIR}/try_compile_glibcxx_use_cxx_abi.cc)
+ file(WRITE ${GLIBCXX_USE_CXX11_ABI_SOURCE} "#if !_GLIBCXX_USE_CXX11_ABI\n"
+ "#error Not using CXX11 ABI\n" "#endif\n")
+ try_compile(IS_GLIBCXX_USE_CXX11_ABI ${CMAKE_CURRENT_BINARY_DIR}/try_compile
+ SOURCES ${GLIBCXX_USE_CXX11_ABI_SOURCE})
+ if(NOT IS_GLIBCXX_USE_CXX11_ABI)
+ string(APPEND ARROW_PC_CFLAGS " -D_GLIBCXX_USE_CXX11_ABI=0")
+ endif()
+endif()
Review Comment:
Yes, this is needed.
devtoolset-8 uses `_GLIBCXX_USE_CXX11_ABI=0` by default. So we don't need to specify it explicitly for our R package on CentOS 7.
But g++ on Ubuntu 18.04/20.04 uses `_GLIBCXX_USE_CXX11_ABI=1` by default. If we mix `_GLIBCXX_USE_CXX11_ABI=0` Apache Arrow C++ binaries (built on CentOS 7) and `_GLIBCXX_USE_CXX11_ABI=1` our R package, our R package can't find needed symbols. It causes a link error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on a diff in pull request #34048: GH-32292: [R][Packaging] Use binaries build on CentOS 7 for Ubuntu < 22.04
Posted by "nealrichardson (via GitHub)" <gi...@apache.org>.
nealrichardson commented on code in PR #34048:
URL: https://github.com/apache/arrow/pull/34048#discussion_r1098932619
##########
ci/scripts/r_install_system_dependencies.sh:
##########
@@ -37,10 +37,10 @@ if [ "$ARROW_S3" == "ON" ] || [ "$ARROW_GCS" == "ON" ] || [ "$ARROW_R_DEV" == "T
# Install curl and OpenSSL for S3/GCS support
case "$PACKAGE_MANAGER" in
apt-get)
- apt-get install -y libcurl4-openssl-dev libssl-dev
+ apt-get install -y libcurl4-openssl-dev libssl-dev pkg-config
Review Comment:
I'd rather ship a binary that just works. Would it be terrible to grep for the CXX11_ABI in arrow.pc and add it to `PKG_CFLAGS`?
If we were to set `LIBARROW_BINARY=false` if no pkg-config, it should be in its own `"${PKG_CONFIG_AVAILABLE}" = "false"` check, not connected to whatever the value of `ARROW_DEPENDENCY_SOURCE` is since that's about building libarrow from source.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34048: GH-32292: [R][Packaging] Use binaries build on CentOS 7 for Ubuntu < 22.04
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34048:
URL: https://github.com/apache/arrow/pull/34048#issuecomment-1418682513
:warning: GitHub issue #32292 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34048: GH-32292: [R][Packaging] Use binaries build on CentOS 7 for Ubuntu < 22.04
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34048:
URL: https://github.com/apache/arrow/pull/34048#issuecomment-1418682451
* Closes: #32292
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #34048: GH-32292: [R][Packaging] Use binaries build on CentOS 7 for Ubuntu < 22.04
Posted by "nealrichardson (via GitHub)" <gi...@apache.org>.
nealrichardson commented on PR #34048:
URL: https://github.com/apache/arrow/pull/34048#issuecomment-1425933180
Ok, so we're back to needing three different binaries then, essentially for each version of openssl. Would the broadest compatibility be to build them all with CentOS 7 + devtoolset 8, just with openssl 1 (default on the machine), openssl 1.1, and openssl 3. Using CentOS 7 would have the oldest glibc version, so it would work everywhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34048: GH-32292: [R][Packaging] Use binaries build on CentOS 7 for Ubuntu < 22.04
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34048:
URL: https://github.com/apache/arrow/pull/34048#issuecomment-1425139204
Revision: 3fef246e50faff0274d6b4de3f4eb3a094ca0cc0
Submitted crossbow builds: [ursacomputing/crossbow @ actions-3324d05836](https://github.com/ursacomputing/crossbow/branches/all?query=actions-3324d05836)
|Task|Status|
|----|------|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/4140689913/jobs/7159582428)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #34048: GH-32292: [R][Packaging] Use binaries built on CentOS 7 for Ubuntu < 22.04
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #34048:
URL: https://github.com/apache/arrow/pull/34048#issuecomment-1478843025
I'll merge this tomorrow if nobody objects it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34048: GH-32292: [R][Packaging] Use binaries built on CentOS 7 for Ubuntu < 22.04
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34048:
URL: https://github.com/apache/arrow/pull/34048#issuecomment-1477184899
Revision: 16ef2dd795f6080455285995011520b75d5b8576
Submitted crossbow builds: [ursacomputing/crossbow @ actions-f45e227409](https://github.com/ursacomputing/crossbow/branches/all?query=actions-f45e227409)
|Task|Status|
|----|------|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/4474841368/jobs/7863687541)|
|test-alpine-linux-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4474841705/jobs/7863688131)|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions/runs/4474841237/jobs/7863687394)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4474841474/jobs/7863687720)|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/runs/12148275561)|
|test-cuda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4474842745/jobs/7863689839)|
|test-debian-10-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4474842325/jobs/7863689173)|
|test-debian-10-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/4474842200/jobs/7863688978)|
|test-debian-11-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4474842565/jobs/7863689570)|
|test-debian-11-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/4474843402/jobs/7863690859)|
|test-fedora-35-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4474841834/jobs/7863688317)|
|test-ubuntu-18.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4474841594/jobs/7863688029)|
|test-ubuntu-18.04-cpp-release|[](https://github.com/ursacomputing/crossbow/actions/runs/4474842064/jobs/7863688758)|
|test-ubuntu-18.04-cpp-static|[](https://github.com/ursacomputing/crossbow/actions/runs/4474843573/jobs/7863691123)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4474843082/jobs/7863690360)|
|test-ubuntu-20.04-cpp-20|[](https://github.com/ursacomputing/crossbow/actions/runs/4474843243/jobs/7863690588)|
|test-ubuntu-20.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/4474841945/jobs/7863688516)|
|test-ubuntu-20.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/4474842924/jobs/7863690069)|
|test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4474843678/jobs/7863691282)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on pull request #34048: GH-32292: [R][Packaging] Use binaries built on CentOS 7 for Ubuntu < 22.04
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on PR #34048:
URL: https://github.com/apache/arrow/pull/34048#issuecomment-1477183280
@github-actions crossbow submit -g cpp r-binary-packages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34048: GH-32292: [R][Packaging] Use binaries build on CentOS 7 for Ubuntu < 22.04
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34048:
URL: https://github.com/apache/arrow/pull/34048#issuecomment-1418685658
Revision: 9d58e2c5e8d8cb030e324b9251f5bb4f011ae1db
Submitted crossbow builds: [ursacomputing/crossbow @ actions-b1fcfc4645](https://github.com/ursacomputing/crossbow/branches/all?query=actions-b1fcfc4645)
|Task|Status|
|----|------|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/4101677410/jobs/7073739137)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #34048: GH-32292: [R][Packaging] Use binaries build on CentOS 7 for Ubuntu < 22.04
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #34048:
URL: https://github.com/apache/arrow/pull/34048#discussion_r1098383768
##########
ci/scripts/r_install_system_dependencies.sh:
##########
@@ -37,10 +37,10 @@ if [ "$ARROW_S3" == "ON" ] || [ "$ARROW_GCS" == "ON" ] || [ "$ARROW_R_DEV" == "T
# Install curl and OpenSSL for S3/GCS support
case "$PACKAGE_MANAGER" in
apt-get)
- apt-get install -y libcurl4-openssl-dev libssl-dev
+ apt-get install -y libcurl4-openssl-dev libssl-dev pkg-config
Review Comment:
> How common is it to be on ubuntu and not have pkg-config installed?
Hmm. I'm not sure preference of R users on Ubuntu but I think that users who have GCC also have pkg-config.
But `rocker/r-ver:4.0.0` and `rocker/r-ver:3.6.3` doesn't have pkg-config. So we need this.
> Does this mean we would require pkg-config in order for the binary to be used?
Yes.
We can fallback to source build when a user doesn't have pkg-config:
```diff
diff --git a/r/configure b/r/configure
index ff6a9dacc4..08fa58d327 100755
--- a/r/configure
+++ b/r/configure
@@ -176,6 +176,7 @@ else
if [ "${ARROW_DEPENDENCY_SOURCE}" = "AUTO" ] && \
[ "${PKG_CONFIG_AVAILABLE}" = "false" ]; then
export ARROW_DEPENDENCY_SOURCE=BUNDLED
+ export LIBARROW_BINARY=false
echo "**** pkg-config not installed, setting ARROW_DEPENDENCY_SOURCE=BUNDLED"
fi
```
Do you want me to add this change to this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #34048: GH-32292: [R][Packaging] Use binaries built on CentOS 7 for Ubuntu < 22.04
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #34048:
URL: https://github.com/apache/arrow/pull/34048#issuecomment-1475024940
@github-actions crossbow submit r-binary-packages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34048: GH-32292: [R][Packaging] Use binaries built on CentOS 7 for Ubuntu < 22.04
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34048:
URL: https://github.com/apache/arrow/pull/34048#issuecomment-1475084106
Revision: e1d6e53f879293c08f610a21b8fa3ada99bbc7e0
Submitted crossbow builds: [ursacomputing/crossbow @ actions-2c85b121dd](https://github.com/ursacomputing/crossbow/branches/all?query=actions-2c85b121dd)
|Task|Status|
|----|------|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/4458644318/jobs/7830592497)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34048: GH-32292: [R][Packaging] Use binaries built on CentOS 7 for Ubuntu < 22.04
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34048:
URL: https://github.com/apache/arrow/pull/34048#issuecomment-1475406862
Revision: 16ef2dd795f6080455285995011520b75d5b8576
Submitted crossbow builds: [ursacomputing/crossbow @ actions-995b248789](https://github.com/ursacomputing/crossbow/branches/all?query=actions-995b248789)
|Task|Status|
|----|------|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/4462823204/jobs/7837623346)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #34048: GH-32292: [R][Packaging] Use binaries built on CentOS 7 for Ubuntu < 22.04
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #34048:
URL: https://github.com/apache/arrow/pull/34048#discussion_r1143405230
##########
r/tools/nixlibs.R:
##########
@@ -99,8 +99,8 @@ download_binary <- function(lib) {
# * Some other string: a "distro-version" that corresponds to a binary that is
# available, to override what this function may discover by default.
# Possible values are:
-# * "centos-7" (gcc 8 (devtoolset), openssl 1, glib 2.17)
-# * "ubuntu-18.04" (gcc 8, openssl 1, glib 2.27)
+# * "centos-7" (gcc 8 (devtoolset), _GLIBCXX_USE_CXX11_ABI=0, openssl 1.0)
Review Comment:
I'll add `linux-` prefix to them because we have `r-lib__libarrow__bin__windows__arrow-`:
* `centos-7` -> `linux-openssl-1.0`
* `centos-7-openssl-1.1` -> `linux-openssl-1.1`
* `ubuntu-22.04` -> `linux-openssl-3.0`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #34048: GH-32292: [R][Packaging] Use binaries build on CentOS 7 for Ubuntu < 22.04
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #34048:
URL: https://github.com/apache/arrow/pull/34048#issuecomment-1425137383
@github-actions crossbow submit r-binary-packages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #34048: GH-32292: [R][Packaging] Use binaries build on CentOS 7 for Ubuntu < 22.04
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #34048:
URL: https://github.com/apache/arrow/pull/34048#issuecomment-1425167249
@github-actions crossbow submit r-binary-packages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on a diff in pull request #34048: GH-32292: [R][Packaging] Use binaries build on CentOS 7 for Ubuntu < 22.04
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on code in PR #34048:
URL: https://github.com/apache/arrow/pull/34048#discussion_r1097256317
##########
cpp/src/arrow/CMakeLists.txt:
##########
@@ -576,6 +576,19 @@ if(ARROW_BUILD_BUNDLED_DEPENDENCIES)
string(APPEND ARROW_PC_LIBS_PRIVATE " -larrow_bundled_dependencies")
list(INSERT ARROW_STATIC_INSTALL_INTERFACE_LIBS 0 "Arrow::arrow_bundled_dependencies")
endif()
+
+if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
+ set(GLIBCXX_USE_CXX11_ABI_SOURCE
+ ${CMAKE_CURRENT_BINARY_DIR}/try_compile_glibcxx_use_cxx_abi.cc)
+ file(WRITE ${GLIBCXX_USE_CXX11_ABI_SOURCE} "#if !_GLIBCXX_USE_CXX11_ABI\n"
+ "#error Not using CXX11 ABI\n" "#endif\n")
+ try_compile(IS_GLIBCXX_USE_CXX11_ABI ${CMAKE_CURRENT_BINARY_DIR}/try_compile
+ SOURCES ${GLIBCXX_USE_CXX11_ABI_SOURCE})
+ if(NOT IS_GLIBCXX_USE_CXX11_ABI)
+ string(APPEND ARROW_PC_CFLAGS " -D_GLIBCXX_USE_CXX11_ABI=0")
+ endif()
+endif()
Review Comment:
Is this really needed? We have been building and testing the R package with the dts centos 7 binary for a while now and thez worked without this? Or is this needed to use this binary on systems without dts installed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34048: GH-32292: [R][Packaging] Use binaries build on CentOS 7 for Ubuntu < 22.04
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34048:
URL: https://github.com/apache/arrow/pull/34048#issuecomment-1418993055
Revision: 6291f39e74f14fd8d63b36f15c7230aac0ef3ec7
Submitted crossbow builds: [ursacomputing/crossbow @ actions-cb055989be](https://github.com/ursacomputing/crossbow/branches/all?query=actions-cb055989be)
|Task|Status|
|----|------|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/4103537449/jobs/7077874829)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34048: GH-32292: [R][Packaging] Use binaries build on CentOS 7 for Ubuntu < 22.04
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34048:
URL: https://github.com/apache/arrow/pull/34048#issuecomment-1423706276
Revision: 34c5ec7b974ae426c89bd659a0b79b24fb21716f
Submitted crossbow builds: [ursacomputing/crossbow @ actions-9ce80ac597](https://github.com/ursacomputing/crossbow/branches/all?query=actions-9ce80ac597)
|Task|Status|
|----|------|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/4131627598/jobs/7139458613)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34048: GH-32292: [R][Packaging] Use binaries built on CentOS 7 for Ubuntu < 22.04
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34048:
URL: https://github.com/apache/arrow/pull/34048#issuecomment-1477995881
Revision: b7dd9a420caca5190c868475046cf977359f4506
Submitted crossbow builds: [ursacomputing/crossbow @ actions-ce74ddcb8c](https://github.com/ursacomputing/crossbow/branches/all?query=actions-ce74ddcb8c)
|Task|Status|
|----|------|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/4480535932/jobs/7875986001)|
|test-alpine-linux-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4480539323/jobs/7875994239)|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions/runs/4480536315/jobs/7875986688)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4480534509/jobs/7875982715)|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/runs/12164281864)|
|test-cuda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4480538814/jobs/7875992416)|
|test-debian-10-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4480538317/jobs/7875991628)|
|test-debian-10-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/4480539144/jobs/7875993473)|
|test-debian-11-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4480535300/jobs/7875984914)|
|test-debian-11-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/4480535642/jobs/7875985446)|
|test-fedora-35-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4480536594/jobs/7875987418)|
|test-ubuntu-18.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4480537513/jobs/7875989581)|
|test-ubuntu-18.04-cpp-release|[](https://github.com/ursacomputing/crossbow/actions/runs/4480537401/jobs/7875989589)|
|test-ubuntu-18.04-cpp-static|[](https://github.com/ursacomputing/crossbow/actions/runs/4480535211/jobs/7875984224)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4480535329/jobs/7875984881)|
|test-ubuntu-20.04-cpp-20|[](https://github.com/ursacomputing/crossbow/actions/runs/4480538158/jobs/7875991311)|
|test-ubuntu-20.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/4480536806/jobs/7875987977)|
|test-ubuntu-20.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/4480537082/jobs/7875988361)|
|test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4480534332/jobs/7875982324)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #34048: GH-32292: [R][Packaging] Use binaries built on CentOS 7 for Ubuntu < 22.04
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #34048:
URL: https://github.com/apache/arrow/pull/34048#issuecomment-1475461419
@nealrichardson This is ready to merge.
This replaces the `ubuntu-18.04` binaries with the `centos-7-openssl-1.1` binaries. The `centos-7-openssl-1.1` binaries uses OpenSSL 1.1 but built on CentOS 7 instead of Ubuntu 18.04. The `centos-7-openssl-1.1` binaries work on Debian GNU/Linux buster, Ubuntu 18.04 and Ubuntu 20.04.
This doesn't change `ubuntu-22.04` binaries that is for OpenSSL 3. Because there aren't OpenSSL 3 packages for CentOS 7 and CentOS 7 will reach EOL on 2024-06-30 https://wiki.centos.org/About/Product . I think that we don't want to maintain CentOS 7 + OpenSSL 3.
Do you have any concern?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #34048: GH-32292: [R][Packaging] Use binaries built on CentOS 7 for Ubuntu < 22.04
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #34048:
URL: https://github.com/apache/arrow/pull/34048#issuecomment-1475391551
@github-actions crossbow submit r-binary-packages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #34048: GH-32292: [R][Packaging] Use binaries built on CentOS 7 for Ubuntu < 22.04
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #34048:
URL: https://github.com/apache/arrow/pull/34048#issuecomment-1475052938
@github-actions crossbow submit r-binary-packages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser merged pull request #34048: GH-32292: [R][Packaging] Use binaries built on CentOS 7 for Ubuntu < 22.04
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser merged PR #34048:
URL: https://github.com/apache/arrow/pull/34048
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #34048: GH-32292: [R][Packaging] Use binaries build on CentOS 7 for Ubuntu < 22.04
Posted by "nealrichardson (via GitHub)" <gi...@apache.org>.
nealrichardson commented on PR #34048:
URL: https://github.com/apache/arrow/pull/34048#issuecomment-1421091916
If upgrading aws-sdk-cpp solves it, great, but doesn't google-cloud also require openssl?
Could we bundle openssl rather than require it from the system? I think the answer from last time I asked this was "no because security", but also as I understand it, the python wheels include openssl in them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #34048: GH-32292: [R][Packaging] Use binaries build on CentOS 7 for Ubuntu < 22.04
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #34048:
URL: https://github.com/apache/arrow/pull/34048#issuecomment-1423704737
@github-actions crossbow submit r-binary-packages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34048: GH-32292: [R][Packaging] Use binaries build on CentOS 7 for Ubuntu < 22.04
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34048:
URL: https://github.com/apache/arrow/pull/34048#issuecomment-1425168474
Revision: 945ecdd70e6f4a88d7e8671206ed93734a7fa037
Submitted crossbow builds: [ursacomputing/crossbow @ actions-3d2d586ec6](https://github.com/ursacomputing/crossbow/branches/all?query=actions-3d2d586ec6)
|Task|Status|
|----|------|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/4140935566/jobs/7160057196)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34048: GH-32292: [R][Packaging] Use binaries built on CentOS 7 for Ubuntu < 22.04
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34048:
URL: https://github.com/apache/arrow/pull/34048#issuecomment-1474916091
Revision: f16f7b85650410f335f248b569edf6f36d084210
Submitted crossbow builds: [ursacomputing/crossbow @ actions-e319432ffe](https://github.com/ursacomputing/crossbow/branches/all?query=actions-e319432ffe)
|Task|Status|
|----|------|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/4456418927/jobs/7826864750)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #34048: GH-32292: [R][Packaging] Use binaries built on CentOS 7 for Ubuntu < 22.04
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #34048:
URL: https://github.com/apache/arrow/pull/34048#issuecomment-1474917345
@github-actions crossbow submit r-binary-packages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on a diff in pull request #34048: GH-32292: [R][Packaging] Use binaries built on CentOS 7 for Ubuntu < 22.04
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on code in PR #34048:
URL: https://github.com/apache/arrow/pull/34048#discussion_r1142829729
##########
r/tools/nixlibs.R:
##########
@@ -99,8 +99,8 @@ download_binary <- function(lib) {
# * Some other string: a "distro-version" that corresponds to a binary that is
# available, to override what this function may discover by default.
# Possible values are:
-# * "centos-7" (gcc 8 (devtoolset), openssl 1, glib 2.17)
-# * "ubuntu-18.04" (gcc 8, openssl 1, glib 2.27)
+# * "centos-7" (gcc 8 (devtoolset), _GLIBCXX_USE_CXX11_ABI=0, openssl 1.0)
Review Comment:
I think renaming the other centos7 binary would communicate the difference between the two better (without having to look in nixlibs.R)?
```suggestion
# * "centos-7-openssl-1.0" (gcc 8 (devtoolset), _GLIBCXX_USE_CXX11_ABI=0, openssl 1.0)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #34048: GH-32292: [R][Packaging] Use binaries built on CentOS 7 for Ubuntu < 22.04
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #34048:
URL: https://github.com/apache/arrow/pull/34048#issuecomment-1479359697
Benchmark runs are scheduled for baseline = 5b49d0f1b11160dc6b38d5ec80aa7f2d46737c9b and contender = 928827515bfbd99060d04ccb754646a76a20f7ec. 928827515bfbd99060d04ccb754646a76a20f7ec is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/c1c5373c83824519a077930986fe3f62...af3110165ecc42138e86e63721281c1b/)
[Failed :arrow_down:0.36% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/c68754420bae46369c6609ac37c4498f...a5560d9765694bacb6ab3fdf3d2b0154/)
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/cdff0e8965174628b858557bf1862950...d514336ddbe64e30a6287162229d8485/)
[Finished :arrow_down:0.03% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/dbbb53e3b3484dcd91dbf654d1608a25...d08259ded50f4952923e119904e22c36/)
Buildkite builds:
[Finished] [`92882751` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2553)
[Finished] [`92882751` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2583)
[Finished] [`92882751` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2551)
[Finished] [`92882751` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2574)
[Finished] [`5b49d0f1` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2552)
[Failed] [`5b49d0f1` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2582)
[Finished] [`5b49d0f1` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2550)
[Finished] [`5b49d0f1` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2573)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #34048: GH-32292: [R][Packaging] Use binaries built on CentOS 7 for Ubuntu < 22.04
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #34048:
URL: https://github.com/apache/arrow/pull/34048#issuecomment-1478656254
@github-actions crossbow submit r-binary-packages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #34048: GH-32292: [R][Packaging] Use binaries built on CentOS 7 for Ubuntu < 22.04
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #34048:
URL: https://github.com/apache/arrow/pull/34048#discussion_r1143399017
##########
r/tools/nixlibs.R:
##########
@@ -99,8 +99,8 @@ download_binary <- function(lib) {
# * Some other string: a "distro-version" that corresponds to a binary that is
# available, to override what this function may discover by default.
# Possible values are:
-# * "centos-7" (gcc 8 (devtoolset), openssl 1, glib 2.17)
-# * "ubuntu-18.04" (gcc 8, openssl 1, glib 2.27)
+# * "centos-7" (gcc 8 (devtoolset), _GLIBCXX_USE_CXX11_ABI=0, openssl 1.0)
Review Comment:
I kept the `centos-7` name for backward compatibility. (I thought that some users may specify `centos-7` explicitly.)
I'll rename them as the followings:
* `centos-7` -> `openssl-1.0`
* `centos-7-openssl-1.1` -> `openssl-1.1`
* `ubuntu-22.04` -> `openssl-3.0`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org