You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Tom Beerbower <tb...@hortonworks.com> on 2016/04/07 23:35:44 UTC
Review Request 45896: Atlas Integration : Support Atlas HA
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45896/
-----------------------------------------------------------
Review request for Ambari, John Speidel and Nate Cole.
Bugs: AMBARI-15733
https://issues.apache.org/jira/browse/AMBARI-15733
Repository: ambari
Description
-------
1 set cardinality to 1+ in Atlas stack definition
2 expose Atlas configuration to enable HA (atlas.server.ha.enabled)
3 set Atlas configuration for server id list (atlas.server.ids)
4 set Atlas configuration properties for hosts (atlas.server.host.id1, ...)
5 expose Atlas host component ha_state property in Ambari REST API.
6 Update Ambari quick link definition in Atlas stack definition to show ha_state. (See Yarn RM quick links)
* Also refactored HTTPProxyPropertyProvider to remove RM specific code.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java b77fda2
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AtlasServerHttpPropertyRequest.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java 11db913
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HttpPropertyProvider.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HttpProxyPropertyProvider.java e92536c
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/JsonHttpPropertyRequest.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ResourceManagerHttpPropertyRequest.java PRE-CREATION
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py b377757
ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/application-properties.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/metainfo.xml 7061d6b
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AtlasServerHttpPropertyRequestTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HttpPropertyProviderTest.java b622728
Diff: https://reviews.apache.org/r/45896/diff/
Testing
-------
Manual test.
mvn clean test
new unit tests added
Thanks,
Tom Beerbower
Re: Review Request 45896: Atlas Integration : Support Atlas HA
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45896/#review127780
-----------------------------------------------------------
Ship it!
Look at you, back in the mix :)
- Nate Cole
On April 7, 2016, 5:35 p.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45896/
> -----------------------------------------------------------
>
> (Updated April 7, 2016, 5:35 p.m.)
>
>
> Review request for Ambari, John Speidel and Nate Cole.
>
>
> Bugs: AMBARI-15733
> https://issues.apache.org/jira/browse/AMBARI-15733
>
>
> Repository: ambari
>
>
> Description
> -------
>
> 1 set cardinality to 1+ in Atlas stack definition
> 2 expose Atlas configuration to enable HA (atlas.server.ha.enabled)
> 3 set Atlas configuration for server id list (atlas.server.ids)
> 4 set Atlas configuration properties for hosts (atlas.server.host.id1, ...)
> 5 expose Atlas host component ha_state property in Ambari REST API.
> 6 Update Ambari quick link definition in Atlas stack definition to show ha_state. (See Yarn RM quick links)
>
> * Also refactored HTTPProxyPropertyProvider to remove RM specific code.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java b77fda2
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AtlasServerHttpPropertyRequest.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java 11db913
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HttpPropertyProvider.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HttpProxyPropertyProvider.java e92536c
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/JsonHttpPropertyRequest.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ResourceManagerHttpPropertyRequest.java PRE-CREATION
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py b377757
> ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/application-properties.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/metainfo.xml 7061d6b
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AtlasServerHttpPropertyRequestTest.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HttpPropertyProviderTest.java b622728
>
> Diff: https://reviews.apache.org/r/45896/diff/
>
>
> Testing
> -------
>
> Manual test.
>
> mvn clean test
>
> new unit tests added
>
>
> Thanks,
>
> Tom Beerbower
>
>