You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/02/18 14:58:00 UTC

[GitHub] [cloudstack] rafaelweingartner commented on a change in pull request #4702: Improve logs on IpmitoolOutOfBandManagementDriver

rafaelweingartner commented on a change in pull request #4702:
URL: https://github.com/apache/cloudstack/pull/4702#discussion_r578486328



##########
File path: plugins/outofbandmanagement-drivers/ipmitool/src/main/java/org/apache/cloudstack/outofbandmanagement/driver/ipmitool/IpmitoolOutOfBandManagementDriver.java
##########
@@ -37,6 +37,7 @@
 import java.util.List;
 import java.util.concurrent.ExecutorService;
 import java.util.concurrent.Executors;
+import org.apache.commons.lang3.StringUtils;

Review comment:
       There is no consensus on that. I would prefer this way, using the library directly. We do not get benefits on a facade like that.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org