[GitHub] [spark] LuciferYang commented on a diff in pull request #36900: [SPARK-39504][CORE][SQL] No-null object invokes equals method to avoid NPE

[GitBox <gi...@apache.org>]

LuciferYang commented on code in PR #36900:
URL: https://github.com/apache/spark/pull/36900#discussion_r899911591


##########
common/network-common/src/main/java/org/apache/spark/network/TransportContext.java:
##########
@@ -124,7 +124,7 @@ public TransportContext(
     this.closeIdleConnections = closeIdleConnections;
 
     if (conf.getModuleName() != null &&
-        conf.getModuleName().equalsIgnoreCase("shuffle") &&
+        "shuffle".equalsIgnoreCase(conf.getModuleName()) &&

Review Comment:
   hmm... if `conf.getModuleName() != null` is true,  I think NPE won't happen here
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org