[GitHub] [kafka] divijvaidya commented on pull request #12285: KAFKA-14001: Migrate streams module to JUnit 5 - Part 1

[GitBox <gi...@apache.org>]

divijvaidya commented on PR #12285:
URL: https://github.com/apache/kafka/pull/12285#issuecomment-1192428154

   Hey @clolov @cadonna 
   Yes, I have figured out why the newly converted tests to JUnit5 are not running. There are two reasons to it:
   1. There is an overall block to use JUnit5 for streams project at https://github.com/apache/kafka/blob/trunk/build.gradle#L324. [Action] We need to remove streams from here.
   2. The dependency chain does not pull in Jupiter engine dependency instead it pulls in Jupiter API dependency at https://github.com/apache/kafka/blob/trunk/build.gradle#L1839 [Action] We need to replace this with `testImplementation libs.junitJupiter`
   
   I made the above two changes and ensured that the modified test is run using `./gradlew streams:test --tests AdjustStreamThreadCountTest`
   
   With the above changes, we will still have tests which won't execute during build because at https://github.com/apache/kafka/blob/trunk/build.gradle#L466, we will only run tests with "integration" tag. A simple way to fix it is to run all Junit4 and Junit5 tests using the Jupiter platform. It is allowed if we use the [JUnitVintageEngine](https://junit.org/junit5/docs/current/user-guide/#migrating-from-junit4). I will file a pull request soon to fix what I mentioned above.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org