You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2020/02/22 23:18:48 UTC
[GitHub] [guacamole-server] oxcrag opened a new pull request #258: Added
Norwegian keyboard map.
oxcrag opened a new pull request #258: Added Norwegian keyboard map.
URL: https://github.com/apache/guacamole-server/pull/258
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [guacamole-server] mike-jumper commented on a change in pull
request #258: GUACAMOLE-968: Add Norwegian keymap
Posted by GitBox <gi...@apache.org>.
mike-jumper commented on a change in pull request #258: GUACAMOLE-968: Add Norwegian keymap
URL: https://github.com/apache/guacamole-server/pull/258#discussion_r383094832
##########
File path: src/protocols/rdp/Makefile.am
##########
@@ -224,6 +224,7 @@ BUILT_SOURCES = \
rdp_keymaps = \
$(srcdir)/keymaps/base.keymap \
$(srcdir)/keymaps/failsafe.keymap \
+ $(srcdir)/keymaps/da_dk_qwerty.keymap \
Review comment:
Is this from something else?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [guacamole-server] mike-jumper commented on a change in pull
request #258: GUACAMOLE-968: Add Norwegian keymap
Posted by GitBox <gi...@apache.org>.
mike-jumper commented on a change in pull request #258: GUACAMOLE-968: Add Norwegian keymap
URL: https://github.com/apache/guacamole-server/pull/258#discussion_r383120319
##########
File path: src/protocols/rdp/Makefile.am
##########
@@ -224,6 +224,7 @@ BUILT_SOURCES = \
rdp_keymaps = \
$(srcdir)/keymaps/base.keymap \
$(srcdir)/keymaps/failsafe.keymap \
+ $(srcdir)/keymaps/da_dk_qwerty.keymap \
Review comment:
Ah, OK. I didn't see the deletion below. I thought this was adding a keymap that didn't yet exist.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [guacamole-server] oxcrag commented on issue #258: GUACAMOLE-968:
Add Norwegian keymap
Posted by GitBox <gi...@apache.org>.
oxcrag commented on issue #258: GUACAMOLE-968: Add Norwegian keymap
URL: https://github.com/apache/guacamole-server/pull/258#issuecomment-590070429
I fixed the entry order, renamed the pull request, and the commit message for the new version of the files. Is there a way of changing the previous commit message after the fact, or will that do bad things to the pull request/version management?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [guacamole-server] oxcrag commented on a change in pull request
#258: GUACAMOLE-968: Add Norwegian keymap
Posted by GitBox <gi...@apache.org>.
oxcrag commented on a change in pull request #258: GUACAMOLE-968: Add Norwegian keymap
URL: https://github.com/apache/guacamole-server/pull/258#discussion_r383111482
##########
File path: src/protocols/rdp/Makefile.am
##########
@@ -224,6 +224,7 @@ BUILT_SOURCES = \
rdp_keymaps = \
$(srcdir)/keymaps/base.keymap \
$(srcdir)/keymaps/failsafe.keymap \
+ $(srcdir)/keymaps/da_dk_qwerty.keymap \
Review comment:
No, I just figured I'd order the rest of the keymaps in the code block while I put the Norwegian one in its correct place. On the contrary I was unsure about whether to move `failsafe.keymap` to its alphabetical position and decided against it, since it could be argued to be a special case that perhaps deserves special visibility. As you see, I just moved the Danish keymap from directly below the Swedish to its more alphabetically correct position above the German one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [guacamole-server] necouchman commented on issue #258:
GUACAMOLE-968: Add Norwegian keymap
Posted by GitBox <gi...@apache.org>.
necouchman commented on issue #258: GUACAMOLE-968: Add Norwegian keymap
URL: https://github.com/apache/guacamole-server/pull/258#issuecomment-590071103
Also note that the correct format for both PR (which you've done properly) and commit messages is "GUACAMOLE-968: ".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [guacamole-server] oxcrag commented on issue #258: GUACAMOLE-968:
Add Norwegian keymap
Posted by GitBox <gi...@apache.org>.
oxcrag commented on issue #258: GUACAMOLE-968: Add Norwegian keymap
URL: https://github.com/apache/guacamole-server/pull/258#issuecomment-590073382
I'm (slowly) getting the hang of this; thanks again! I think the requested changes are in place now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [guacamole-server] necouchman commented on issue #258:
GUACAMOLE-968: Add Norwegian keymap
Posted by GitBox <gi...@apache.org>.
necouchman commented on issue #258: GUACAMOLE-968: Add Norwegian keymap
URL: https://github.com/apache/guacamole-server/pull/258#issuecomment-590071006
> Is there a way of changing the previous commit message after the fact
Yes, you can do an interactive rebase, choose the option to modify the commit message, and then fix the messages. After you're done do a force push and it should be good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services