You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2024/07/07 11:37:03 UTC
[I] Remove additional unnecessary qualified names in the code [datafusion]
alamb opened a new issue, #11317:
URL: https://github.com/apache/datafusion/issues/11317
### Is your feature request related to a problem or challenge?
As @findepi noted and improved in https://github.com/apache/datafusion/pull/11292, there are places in the DataFusion codebase that use fully (or more fully) qualified names that necessary
For example since `Result` was already in scope via `use arrow_schema::Field` the code can be simplified like this:
```diff
- fn state_fields(&self, args: StateFieldsArgs) -> Result<Vec<arrow_schema::Field>> {
+ fn state_fields(&self, args: StateFieldsArgs) -> Result<Vec<Field>> {
```
As @findepi reportes in https://github.com/apache/datafusion/pull/11292#issuecomment-2211795858:
> RustRover has nice inspections and can detect unnecessary use of qualified names.
> Sadly it can't fix them automatically (yet), so it's currently manual & requires proper review. That's why I fixed only some of these.
### Describe the solution you'd like
It would be nice for someone to review other instances of these unecessary qualified names and remove them too
### Describe alternatives you've considered
_No response_
### Additional context
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Remove additional unnecessary qualified names in the code [datafusion]
Posted by "Weijun-H (via GitHub)" <gi...@apache.org>.
Weijun-H commented on issue #11317:
URL: https://github.com/apache/datafusion/issues/11317#issuecomment-2219948733
Consider if there is a better way to automatically detect this issue in Clippy or other crates. 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Remove additional unnecessary qualified names in the code [datafusion]
Posted by "findepi (via GitHub)" <gi...@apache.org>.
findepi commented on issue #11317:
URL: https://github.com/apache/datafusion/issues/11317#issuecomment-2437202281
seems there is no Clippy check for this (https://github.com/rust-lang/rust-clippy/issues/4707), but there rustc check: `unused_qualifications`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Remove additional unnecessary qualified names in the code [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #11317:
URL: https://github.com/apache/datafusion/issues/11317#issuecomment-2444214264
And we are done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Remove additional unnecessary qualified names in the code [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed issue #11317: Remove additional unnecessary qualified names in the code
URL: https://github.com/apache/datafusion/issues/11317
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Remove additional unnecessary qualified names in the code [datafusion]
Posted by "Weijun-H (via GitHub)" <gi...@apache.org>.
Weijun-H commented on issue #11317:
URL: https://github.com/apache/datafusion/issues/11317#issuecomment-2439603284
Since @findepi suggested a simple and accessible solution, this issue could be a good first issue for new contributors who are unfamiliar with Datafusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Remove additional unnecessary qualified names in the code [datafusion]
Posted by "Weijun-H (via GitHub)" <gi...@apache.org>.
Weijun-H commented on issue #11317:
URL: https://github.com/apache/datafusion/issues/11317#issuecomment-2219788432
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Remove additional unnecessary qualified names in the code [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #11317:
URL: https://github.com/apache/datafusion/issues/11317#issuecomment-2220094166
> Consider if there is a better way to automatically detect this issue in Clippy or other crates. 🤔
I think @findepi said there was some feature in RustRover that did it. A clippy lint would be even better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Remove additional unnecessary qualified names in the code [datafusion]
Posted by "findepi (via GitHub)" <gi...@apache.org>.
findepi commented on issue #11317:
URL: https://github.com/apache/datafusion/issues/11317#issuecomment-2439660392
@Weijun-H thanks for adding the label!
btw @dhegberg is already working on this (https://github.com/apache/datafusion/pull/13086).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org