[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #985: Using FileIO and EncryptionManager for MR InputFiles

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #985:
URL: https://github.com/apache/incubator-iceberg/pull/985#discussion_r417493436



##########
File path: mr/src/main/java/org/apache/iceberg/mr/mapreduce/IcebergInputFormat.java
##########
@@ -572,13 +593,29 @@ public void write(DataOutput out) throws IOException {
       byte[] data = SerializationUtil.serializeToBytes(this.task);
       out.writeInt(data.length);
       out.write(data);
+
+      byte[] ioData = SerializationUtil.serializeToBytes(io);

Review comment:
       @rdsr, I just noticed this. Do we need custom `Serializable` implementations? If all of the fields are `Serializable` and this is `Serializable` then the default implementation should just work.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org