You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/05 00:35:34 UTC
[GitHub] [beam] damccorm opened a new issue, #21634: Improvements to RowWithGetter
damccorm opened a new issue, #21634:
URL: https://github.com/apache/beam/issues/21634
Various improvements to getValue(fieldIdx) in RowWithGetters mentioned [here]([https://github.com/apache/beam/pull/16947#discussion_r833602836):]
* Minimize memory overhead of cache using either a index lookup (array) or a single hash map if number of fields exceeds the initial hashmap capacity
* The cache should be checked before calling a getter to avoid any potentially unnecessary conversion in the getter itself.
* [Nested rows](https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/values/RowWithGetters.java#L111) should be cached, otherwise the cache of such nested rows can't be leveraged.
* Handling of collections / maps / iterables can be significantly improved by simply skipping the transform in all cases where `getValue` for members is the [identity transform](https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/values/RowWithGetters.java#L142).
Imported from Jira [BEAM-14166](https://issues.apache.org/jira/browse/BEAM-14166). Original Jira may contain additional context.
Reported by: mosche.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mosche closed issue #21634: Improvements to RowWithGetter
Posted by GitBox <gi...@apache.org>.
mosche closed issue #21634: Improvements to RowWithGetter
URL: https://github.com/apache/beam/issues/21634
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org