You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/11/26 03:37:11 UTC
[GitHub] [incubator-pinot] codecov-io commented on issue #4858: Introduce
the base JSON config class and clean up the config classes
codecov-io commented on issue #4858: Introduce the base JSON config class and clean up the config classes
URL: https://github.com/apache/incubator-pinot/pull/4858#issuecomment-558444915
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4858?src=pr&el=h1) Report
> Merging [#4858](https://codecov.io/gh/apache/incubator-pinot/pull/4858?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/c0f8b7a5736f860b338a06d9a76f1bc47125c272?src=pr&el=desc) will **increase** coverage by `0.19%`.
> The diff coverage is `71.91%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/4858?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4858 +/- ##
============================================
+ Coverage 57.53% 57.72% +0.19%
Complexity 4 4
============================================
Files 1197 1198 +1
Lines 65011 64659 -352
Branches 9459 9392 -67
============================================
- Hits 37402 37323 -79
+ Misses 24851 24565 -286
- Partials 2758 2771 +13
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4858?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...e/assignment/instance/InstanceTagPoolSelector.java](https://codecov.io/gh/apache/incubator-pinot/pull/4858/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL2Fzc2lnbm1lbnQvaW5zdGFuY2UvSW5zdGFuY2VUYWdQb29sU2VsZWN0b3IuamF2YQ==) | `96.29% <ø> (-0.07%)` | `0 <0> (ø)` | |
| [...he/pinot/tools/admin/command/AddTenantCommand.java](https://codecov.io/gh/apache/incubator-pinot/pull/4858/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL2FkbWluL2NvbW1hbmQvQWRkVGVuYW50Q29tbWFuZC5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...g/apache/pinot/tools/perf/PerfBenchmarkDriver.java](https://codecov.io/gh/apache/incubator-pinot/pull/4858/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL3BlcmYvUGVyZkJlbmNobWFya0RyaXZlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...rg/apache/pinot/common/config/TableTaskConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/4858/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vY29uZmlnL1RhYmxlVGFza0NvbmZpZy5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...pache/pinot/common/config/StarTreeIndexConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/4858/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vY29uZmlnL1N0YXJUcmVlSW5kZXhDb25maWcuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../java/org/apache/pinot/common/config/Instance.java](https://codecov.io/gh/apache/incubator-pinot/pull/4858/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vY29uZmlnL0luc3RhbmNlLmphdmE=) | `75.67% <0%> (-0.65%)` | `0 <0> (ø)` | |
| [...g/apache/pinot/common/config/CompletionConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/4858/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vY29uZmlnL0NvbXBsZXRpb25Db25maWcuamF2YQ==) | `100% <100%> (+45.45%)` | `0 <0> (ø)` | :arrow_down: |
| [.../instance/InstanceReplicaGroupPartitionConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/4858/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vY29uZmlnL2luc3RhbmNlL0luc3RhbmNlUmVwbGljYUdyb3VwUGFydGl0aW9uQ29uZmlnLmphdmE=) | `100% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...config/instance/InstanceAssignmentConfigUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4858/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vY29uZmlnL2luc3RhbmNlL0luc3RhbmNlQXNzaWdubWVudENvbmZpZ1V0aWxzLmphdmE=) | `76.47% <100%> (-3.02%)` | `0 <0> (ø)` | |
| [...va/org/apache/pinot/common/config/QuotaConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/4858/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vY29uZmlnL1F1b3RhQ29uZmlnLmphdmE=) | `96.29% <100%> (+25.24%)` | `0 <0> (ø)` | :arrow_down: |
| ... and [51 more](https://codecov.io/gh/apache/incubator-pinot/pull/4858/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4858?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4858?src=pr&el=footer). Last update [c0f8b7a...7b53e85](https://codecov.io/gh/apache/incubator-pinot/pull/4858?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org