You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/03/06 08:43:47 UTC
[GitHub] [incubator-pinot] snleee commented on issue #3913: Adding the
support for sampling logs
snleee commented on issue #3913: Adding the support for sampling logs
URL: https://github.com/apache/incubator-pinot/pull/3913#issuecomment-470019680
@kishoreg We currently log within `QueryScheduler` in server and `BaseBrokerHandler` in broker. Unless we log in the separate thread, we should not use rate limiter since it will block threads in the critical path. Even if we write logs in a separate thread, task queue will grow indefinitely if incoming logs are queueing much faster than `maxRate`. How do we address this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org