You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@uniffle.apache.org by "zuston (via GitHub)" <gi...@apache.org> on 2023/02/20 06:46:20 UTC
[GitHub] [incubator-uniffle] zuston opened a new issue, #630: [FEATURE] Disable the localShuffleRead in Spark client
zuston opened a new issue, #630:
URL: https://github.com/apache/incubator-uniffle/issues/630
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
### Search before asking
- [X] I have searched in the [issues](https://github.com/apache/incubator-uniffle/issues?q=is%3Aissue) and found no similar issues.
### Describe the feature
The conf of `spark.sql.adaptive.localShuffleReader.enabled` should be false when using uniffle.
We'd better to disable it by default in `RssShuffleManager`
### Motivation
_No response_
### Describe the solution
_No response_
### Additional context
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] zuston closed issue #630: [FEATURE] Disable the localShuffleRead in Spark client
Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston closed issue #630: [FEATURE] Disable the localShuffleRead in Spark client
URL: https://github.com/apache/incubator-uniffle/issues/630
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] jerqi commented on issue #630: [FEATURE] Disable the localShuffleRead in Spark client
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on issue #630:
URL: https://github.com/apache/incubator-uniffle/issues/630#issuecomment-1436793742
Ok for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] zuston commented on issue #630: [FEATURE] Disable the localShuffleRead in Spark client
Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston commented on issue #630:
URL: https://github.com/apache/incubator-uniffle/issues/630#issuecomment-1436416524
PTAL @jerqi @advancedxy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] advancedxy commented on issue #630: [FEATURE] Disable the localShuffleRead in Spark client
Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on issue #630:
URL: https://github.com/apache/incubator-uniffle/issues/630#issuecomment-1437775236
+1 for this. And it's better to add some explanation how local shuffle reader work and why it's better to turn off this optimization when using RssShuffleManager.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org