[jira] [Commented] (NUTCH-2969) Javadoc: Javascript search is not working when built on JDK 11

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NUTCH-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17582974#comment-17582974 ] 

ASF GitHub Bot commented on NUTCH-2969:
---------------------------------------

sebastian-nagel opened a new pull request, #749:
URL: https://github.com/apache/nutch/pull/749

   - pass --no-module-directories to javadoc target when building on JDK 11
   - remove obsolete condition to fail javadoc builds on JDK 7u25 and earlier
   




> Javadoc: Javascript search is not working when built on JDK 11
> --------------------------------------------------------------
>
>                 Key: NUTCH-2969
>                 URL: https://issues.apache.org/jira/browse/NUTCH-2969
>             Project: Nutch
>          Issue Type: Bug
>          Components: build, documentation
>    Affects Versions: 1.19
>            Reporter: Sebastian Nagel
>            Assignee: Sebastian Nagel
>            Priority: Major
>             Fix For: 1.19
>
>
> Newer Java versions create a nice Javascript-backed search box on the Javadocs. When built on JDK 11 clicking on search results leads to 404 results with a {{/undefined/}} path element in the URL. This is caused by [JDK-8215291|https://bugs.openjdk.org/browse/JDK-8215291] - Nutch does not use Java modules.
> The issue can be solved by adding {{--no-module-directories}} as argument to the {{javadoc}} command. However, this only works for JDK 11 and will break the javadoc build for later JDK versions, see [JDK-8215582|https://bugs.openjdk.org/browse/JDK-8215582]. 
> See also
> - https://stackoverflow.com/questions/52326318/maven-javadoc-search-redirects-to-undefined-url
> - https://github.com/crawler-commons/crawler-commons/pull/380
> Notes:
> - seen while preparing a release candidate for 1.19 (will quickly commit the solution)
> - adding {{--no-module-directories}} should be conditional for JDK 11 only
> -* ant: see [condition|https://ant.apache.org/manual/Tasks/condition.html]
> -* gradle:
> {noformat}
> if (JavaVersion.current().isJava11()) {
>   options.addBooleanOption("-no-module-directories", true)
> }
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)