[GitHub] [accumulo] DomGarguilo commented on a change in pull request #2255: Added Fix for #2227

[GitBox <gi...@apache.org>]

DomGarguilo commented on a change in pull request #2255:
URL: https://github.com/apache/accumulo/pull/2255#discussion_r705492341



##########
File path: shell/src/main/java/org/apache/accumulo/shell/commands/ScanCommand.java
##########
@@ -285,6 +288,19 @@ protected void fetchColumns(final CommandLine cl, final ScannerBase scanner,
     }
   }
 
+  protected String[] extractColumnFamily(final String columnString) {

Review comment:
       This might be able to be simplified by just using the substring method. Also it doesn't seem like this accounts for strings where there are more than 2 ':' characters (not sure if that will ever be the case), for example `a:c:d:e` would be sent to the `else` branch and possibly handled incorrectly (not sure if that will ever be the case). 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org