You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/12/20 16:38:04 UTC
[GitHub] [airflow] potiuk opened a new pull request, #28498: Move MyPY plugins of ours to dev folder
potiuk opened a new pull request, #28498:
URL: https://github.com/apache/airflow/pull/28498
The Plugins are only used in the static check phase. The problem with having them in "airflow" package is that mypy imports "airlfow" during loading of the plugins and it means that it has to have fully working Airflow configuration to work - otherwise this import fails while reading the configuration values.
Moving the whole mypy plugins to dev solves the problem entirely.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #28498: Move MyPY plugins of ours to dev folder
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #28498:
URL: https://github.com/apache/airflow/pull/28498#issuecomment-1359701473
It will also make "mypy" a bit faster to start because it will not have to import airflow as "regular" package. I beleive that when we had it in airflow, it actually imported "airflow" twice - once to initialize the plugin and second time to import everything with "TYPE_CHECKING". Now only the "TYPE_CHECKING" import remains. It does not perform all the intialization that normally is performed when "airflow" package gets importe, so it shoudl make mypy quite a bit faster (especially when running with few files).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham merged pull request #28498: Move MyPY plugins of ours to dev folder
Posted by GitBox <gi...@apache.org>.
jedcunningham merged PR #28498:
URL: https://github.com/apache/airflow/pull/28498
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #28498: Move MyPY plugins of ours to dev folder
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #28498:
URL: https://github.com/apache/airflow/pull/28498#issuecomment-1359696663
I noticed it while implementing #28495 and realized we shoudl separate it out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org