You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/25 13:03:34 UTC
[GitHub] [apisix-docker] Yiyiyimu opened a new pull request #140: ci: refactor ci and compose
Yiyiyimu opened a new pull request #140:
URL: https://github.com/apache/apisix-docker/pull/140
Signed-off-by: yiyiyimu <wo...@gmail.com>
fix #138
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] gxthrj commented on a change in pull request #140: ci: refactor ci and compose
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #140:
URL: https://github.com/apache/apisix-docker/pull/140#discussion_r584441707
##########
File path: Makefile
##########
@@ -16,23 +16,23 @@
#
default: help
-APISIX_VERSION ?= 2.3
+APISIX_VERSION ?= latest
Review comment:
We still need them
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] Yiyiyimu commented on a change in pull request #140: ci: refactor ci and compose
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on a change in pull request #140:
URL: https://github.com/apache/apisix-docker/pull/140#discussion_r584433376
##########
File path: Makefile
##########
@@ -16,23 +16,23 @@
#
default: help
-APISIX_VERSION ?= 2.3
+APISIX_VERSION ?= latest
Review comment:
Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] gxthrj commented on a change in pull request #140: ci: refactor ci and compose
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #140:
URL: https://github.com/apache/apisix-docker/pull/140#discussion_r584476083
##########
File path: .github/workflows/apisix-docker-test.yaml
##########
@@ -10,16 +10,33 @@ on:
jobs:
build:
+ strategy:
+ fail-fast: false
+ matrix:
+ platform:
+ - alpine
+ - centos
+ - alpine-local
+ env:
Review comment:
:)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] Yiyiyimu commented on a change in pull request #140: ci: refactor ci and compose
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on a change in pull request #140:
URL: https://github.com/apache/apisix-docker/pull/140#discussion_r584444460
##########
File path: Makefile
##########
@@ -16,23 +16,23 @@
#
default: help
-APISIX_VERSION ?= 2.3
+APISIX_VERSION ?= latest
Review comment:
@gxthrj fixed~ PTAL
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] Yiyiyimu commented on a change in pull request #140: ci: refactor ci and compose
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on a change in pull request #140:
URL: https://github.com/apache/apisix-docker/pull/140#discussion_r584433534
##########
File path: Makefile
##########
@@ -16,23 +16,23 @@
#
default: help
-APISIX_VERSION ?= 2.3
+APISIX_VERSION ?= latest
Review comment:
BTW, I removed the image tarball creation and upload, do we still need them
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] Yiyiyimu commented on a change in pull request #140: ci: refactor ci and compose
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on a change in pull request #140:
URL: https://github.com/apache/apisix-docker/pull/140#discussion_r584478402
##########
File path: .github/workflows/apisix-docker-test.yaml
##########
@@ -10,16 +10,33 @@ on:
jobs:
build:
+ strategy:
+ fail-fast: false
+ matrix:
+ platform:
+ - alpine
+ - centos
+ - alpine-local
+ env:
Review comment:
My bad🤣
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] Yiyiyimu commented on a change in pull request #140: ci: refactor ci and compose
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on a change in pull request #140:
URL: https://github.com/apache/apisix-docker/pull/140#discussion_r584475164
##########
File path: .github/workflows/apisix-docker-test.yaml
##########
@@ -10,16 +10,33 @@ on:
jobs:
build:
+ strategy:
+ fail-fast: false
+ matrix:
+ platform:
+ - alpine
+ - centos
+ - alpine-local
+ env:
Review comment:
wait.... format error causing CI not triggered
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] Yiyiyimu merged pull request #140: ci: refactor ci and compose
Posted by GitBox <gi...@apache.org>.
Yiyiyimu merged pull request #140:
URL: https://github.com/apache/apisix-docker/pull/140
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] gxthrj commented on a change in pull request #140: ci: refactor ci and compose
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #140:
URL: https://github.com/apache/apisix-docker/pull/140#discussion_r583388704
##########
File path: Makefile
##########
@@ -16,23 +16,23 @@
#
default: help
-APISIX_VERSION ?= 2.3
+APISIX_VERSION ?= latest
Review comment:
The version should be 2.3
We discussed before and decided to modify this version number to trigger CI after each APISIX release.
##########
File path: .github/workflows/apisix-docker-test.yaml
##########
@@ -10,17 +10,32 @@ on:
jobs:
build:
+ strategy:
+ fail-fast: false
+ matrix:
+ platform:
+ - alpine
+ - centos
+ - alpine-local
+
runs-on: ubuntu-latest
+ env:
+ APISIX_PATH: "./apisix-local"
steps:
- uses: actions/checkout@v2
- - name: Build and run
+
+ - name: Clone apisix for local test
+ if: ${{ matrix.platform == 'alpine-local' }}
run: |
git clone http://github.com/apache/apisix apisix-local
- export APISIX_PATH="./apisix-local"
- make build-on-alpine-local
- docker-compose -f ./alpine-local/docker-compose.yaml up -d
+
+ - name: Build and run
+ run: |
+ make build-on-${{ matrix.platform }}
Review comment:
👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org