You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by gatorsmile <gi...@git.apache.org> on 2018/04/03 17:53:23 UTC
[GitHub] spark pull request #20969: [SPARK-23826] [TEST] TestHiveSparkSession should ...
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/20969
[SPARK-23826] [TEST] TestHiveSparkSession should set default session
## What changes were proposed in this pull request?
In TestHive, the base spark session does this in getOrCreate(), we emulate that behavior for tests.
## How was this patch tested?
N/A
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gatorsmile/spark setDefault
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/20969.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20969
----
commit 228730b2582daf506bc5126eb7d1144ec6f295cb
Author: gatorsmile <ga...@...>
Date: 2018-04-03T17:50:57Z
fix.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20969: [SPARK-23826] [TEST] TestHiveSparkSession should set def...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20969
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20969: [SPARK-23826] [TEST] TestHiveSparkSession should ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20969
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20969: [SPARK-23826] [TEST] TestHiveSparkSession should set def...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20969
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20969: [SPARK-23826] [TEST] TestHiveSparkSession should set def...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20969
cc @marmbrus @ericl @jose-torres @cloud-fan
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20969: [SPARK-23826] [TEST] TestHiveSparkSession should set def...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20969
**[Test build #88872 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88872/testReport)** for PR 20969 at commit [`f7e0b03`](https://github.com/apache/spark/commit/f7e0b034026691872c905ab4d5d09c381c56b7b0).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20969: [SPARK-23826] [TEST] TestHiveSparkSession should set def...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20969
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20969: [SPARK-23826] [TEST] TestHiveSparkSession should set def...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20969
**[Test build #88852 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88852/testReport)** for PR 20969 at commit [`228730b`](https://github.com/apache/spark/commit/228730b2582daf506bc5126eb7d1144ec6f295cb).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20969: [SPARK-23826] [TEST] TestHiveSparkSession should set def...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20969
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88872/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20969: [SPARK-23826] [TEST] TestHiveSparkSession should set def...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20969
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1925/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20969: [SPARK-23826] [TEST] TestHiveSparkSession should set def...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20969
**[Test build #88852 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88852/testReport)** for PR 20969 at commit [`228730b`](https://github.com/apache/spark/commit/228730b2582daf506bc5126eb7d1144ec6f295cb).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20969: [SPARK-23826] [TEST] TestHiveSparkSession should set def...
Posted by jose-torres <gi...@git.apache.org>.
Github user jose-torres commented on the issue:
https://github.com/apache/spark/pull/20969
lgtm
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20969: [SPARK-23826] [TEST] TestHiveSparkSession should set def...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20969
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20969: [SPARK-23826] [TEST] TestHiveSparkSession should set def...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20969
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1942/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20969: [SPARK-23826] [TEST] TestHiveSparkSession should set def...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20969
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88852/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20969: [SPARK-23826] [TEST] TestHiveSparkSession should ...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20969#discussion_r179020152
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/test/TestHive.scala ---
@@ -159,9 +159,10 @@ private[hive] class TestHiveSparkSession(
private val loadTestTables: Boolean)
extends SparkSession(sc) with Logging { self =>
- // TODO(SPARK-23826): TestHiveSparkSession should set default session the same way as
- // TestSparkSession, but doing this the same way breaks many tests in the package. We need
- // to investigate and find a different strategy.
+ // The base spark session does this in getOrCreate(), here we emulate that behavior for tests.
+ if (SparkSession.getDefaultSession.isEmpty) {
+ SparkSession.setDefaultSession(this)
+ }
--- End diff --
This is not needed after we merge https://github.com/apache/spark/pull/20927
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20969: [SPARK-23826] [TEST] TestHiveSparkSession should set def...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20969
thanks, merging to master!
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20969: [SPARK-23826] [TEST] TestHiveSparkSession should set def...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20969
**[Test build #88872 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88872/testReport)** for PR 20969 at commit [`f7e0b03`](https://github.com/apache/spark/commit/f7e0b034026691872c905ab4d5d09c381c56b7b0).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org