You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/12/03 05:21:10 UTC

[GitHub] [camel] sekikn opened a new pull request, #8828: CAMEL-18792: camel-hdfs - Make integration tests runnable without a real cluster

sekikn opened a new pull request, #8828:
URL: https://github.com/apache/camel/pull/8828

   - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
   - [x] Each commit in the pull request should have a meaningful subject line and body.
   - [x] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
   - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [x] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
   Below are the contribution guidelines:
   https://github.com/apache/camel/blob/main/CONTRIBUTING.md


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] sekikn commented on pull request #8828: CAMEL-18792: camel-hdfs - Make integration tests runnable without a real cluster

Posted by GitBox <gi...@apache.org>.
sekikn commented on PR #8828:
URL: https://github.com/apache/camel/pull/8828#issuecomment-1337431446

   Thanks! Just updated the PR.
   
   With this PR, I ensured all unit and integration tests succeeded, as follows:
   
   ```
   $ cd test-infra/camel-test-infra-hdfs
   $ mvn clean install
   
   ...
   
   [INFO] ------------------------------------------------------------------------
   [INFO] BUILD SUCCESS
   [INFO] ------------------------------------------------------------------------
   [INFO] Total time:  3.056 s
   [INFO] Finished at: 2022-12-05T22:57:03+09:00
   [INFO] ------------------------------------------------------------------------
   $ cd -
   $ cd components/camel-hdfs
   $ LD_LIBRARY_PATH=/home/sekikn/.sdkman/candidates/hadoop/3.2.2/lib/native mvn clean verify
   
   ...
   
   [INFO] --- maven-surefire-plugin:3.0.0-M5:test (default-test) @ camel-hdfs ---
   [INFO] 
   [INFO] -------------------------------------------------------
   [INFO]  T E S T S
   [INFO] -------------------------------------------------------
   [INFO] Running org.apache.camel.component.hdfs.FromFileToHdfsTest
   [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.114 s - in org.apache.camel.component.hdfs.FromFileToHdfsTest
   [INFO] Running org.apache.camel.component.hdfs.HaConfigurationBuilderTest
   [INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.032 s - in org.apache.camel.component.hdfs.HaConfigurationBuilderTest
   [INFO] Running org.apache.camel.component.hdfs.HdfsConsumerTest
   [INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.97 s - in org.apache.camel.component.hdfs.HdfsConsumerTest
   [INFO] Running org.apache.camel.component.hdfs.HdfsInputStreamTest
   [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.033 s - in org.apache.camel.component.hdfs.HdfsInputStreamTest
   [INFO] Running org.apache.camel.component.hdfs.HdfsOutputStreamTest
   [INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.032 s - in org.apache.camel.component.hdfs.HdfsOutputStreamTest
   [INFO] Running org.apache.camel.component.hdfs.HdfsProducerConsumerTest
   [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.34 s - in org.apache.camel.component.hdfs.HdfsProducerConsumerTest
   [INFO] Running org.apache.camel.component.hdfs.HdfsProducerSplitTest
   [INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.516 s - in org.apache.camel.component.hdfs.HdfsProducerSplitTest
   [INFO] Running org.apache.camel.component.hdfs.HdfsProducerTest
   [INFO] Tests run: 20, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 10.486 s - in org.apache.camel.component.hdfs.HdfsProducerTest
   [INFO] Running org.apache.camel.component.hdfs.kerberos.KerberosAuthenticationTest
   [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.008 s - in org.apache.camel.component.hdfs.kerberos.KerberosAuthenticationTest
   [INFO] Running org.apache.camel.component.hdfs.kerberos.KerberosConfigurationBuilderTest
   [INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.003 s - in org.apache.camel.component.hdfs.kerberos.KerberosConfigurationBuilderTest
   [INFO] 
   [INFO] Results:
   [INFO] 
   [INFO] Tests run: 46, Failures: 0, Errors: 0, Skipped: 0
   
   ...
   
   [INFO] --- maven-failsafe-plugin:3.0.0-M4:integration-test (integration-test) @ camel-hdfs ---
   [INFO] 
   [INFO] -------------------------------------------------------
   [INFO]  T E S T S
   [INFO] -------------------------------------------------------
   [INFO] Running org.apache.camel.component.hdfs.integration.HdfsProducerConsumerIntegrationIT
   
   ...
   
   [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 16.908 s - in org.apache.camel.component.hdfs.integration.HdfsProducerConsumerIntegrationIT
   [INFO] Running org.apache.camel.component.hdfs.integration.HdfsConsumerIntegrationIT
   
   ...
   
   [INFO] Tests run: 15, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 9.277 s - in org.apache.camel.component.hdfs.integration.HdfsConsumerIntegrationIT
   [INFO] Running org.apache.camel.component.hdfs.integration.HdfsAppendIT
   
   ...
   
   [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.52 s - in org.apache.camel.component.hdfs.integration.HdfsAppendIT
   [INFO] 
   [INFO] Results:
   [INFO] 
   [INFO] Tests run: 19, Failures: 0, Errors: 0, Skipped: 0
   [INFO] 
   [INFO] 
   [INFO] --- maven-failsafe-plugin:3.0.0-M4:verify (integration-test) @ camel-hdfs ---
   [INFO] ------------------------------------------------------------------------
   [INFO] BUILD SUCCESS
   [INFO] ------------------------------------------------------------------------
   [INFO] Total time:  01:04 min
   [INFO] Finished at: 2022-12-05T22:58:41+09:00
   [INFO] ------------------------------------------------------------------------
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] github-actions[bot] commented on pull request #8828: CAMEL-18792: camel-hdfs - Make integration tests runnable without a real cluster

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8828:
URL: https://github.com/apache/camel/pull/8828#issuecomment-1336065473

   :star2: Thank you for your contribution to the Apache Camel project! :star2: 
   
   :warning: Please note that the changes on this PR may be **tested automatically**. 
   
   If necessary Apache Camel Committers may access logs and test results in the job summaries!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] orpiske commented on pull request #8828: CAMEL-18792: camel-hdfs - Make integration tests runnable without a real cluster

Posted by GitBox <gi...@apache.org>.
orpiske commented on PR #8828:
URL: https://github.com/apache/camel/pull/8828#issuecomment-1336350346

   > Thanks for the comment! I'll fix the PR to leverage AvailablePortFinder. In addition, I've just noticed that there's already camel-test-infra-hdfs in test-infra, so it looks better to fix it to use minicluster (it requires an external cluster now) just like hbase, rather than include minicluster directly into the integration tests. I'll update the PR.
   
   Thanks for your contribution!
   
   +1 for adding it to the `test-infra` component. This could - potentially - also benefit the Camel Kafka Connector project which uses it. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] github-actions[bot] commented on pull request #8828: CAMEL-18792: camel-hdfs - Make integration tests runnable without a real cluster

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8828:
URL: https://github.com/apache/camel/pull/8828#issuecomment-1337523063

   ### Components tested:
   
   | Total | Tested | Failed :x: | Passed :white_check_mark: | 
   | --- | --- | --- |  --- |
   | 1 | 1 | 0 | 1 |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] davsclaus commented on pull request #8828: CAMEL-18792: camel-hdfs - Make integration tests runnable without a real cluster

Posted by GitBox <gi...@apache.org>.
davsclaus commented on PR #8828:
URL: https://github.com/apache/camel/pull/8828#issuecomment-1336115199

   Thanks for helping with this. I wonder if the test used a hardcoded port number (9000 ?) then can we try using AvailablePortFinder which can find a free port number, as CI server may have "port number in use" problem.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] sekikn commented on pull request #8828: CAMEL-18792: camel-hdfs - Make integration tests runnable without a real cluster

Posted by GitBox <gi...@apache.org>.
sekikn commented on PR #8828:
URL: https://github.com/apache/camel/pull/8828#issuecomment-1336303881

   Thanks for the comment! I'll fix the PR to leverage AvailablePortFinder.
   In addition, I've just noticed that there's already camel-test-infra-hdfs in test-infra, so it looks better to fix it to use minicluster (it requires an external cluster now) just like hbase, rather than include minicluster directly into the integration tests. I'll update the PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] orpiske merged pull request #8828: CAMEL-18792: camel-hdfs - Make integration tests runnable without a real cluster

Posted by GitBox <gi...@apache.org>.
orpiske merged PR #8828:
URL: https://github.com/apache/camel/pull/8828


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org