You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by greghogan <gi...@git.apache.org> on 2017/05/15 13:40:29 UTC
[GitHub] flink pull request #3910: [FLINK-6582] [docs] Project from maven archetype i...
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/3910
[FLINK-6582] [docs] Project from maven archetype is not buildable by default
The pom.xml for flink-quickstart-java and flink-quickstart-scala must specify scala.version and scala.binary.version.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/greghogan/flink 6582_project_from_maven_archetype_is_not_buildable
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3910.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3910
----
commit 986ebdb9964a87302c6c26d4eaa431e75b186351
Author: Greg Hogan <co...@greghogan.com>
Date: 2017-05-15T13:35:36Z
[FLINK-6582] [docs] Project from maven archetype is not buildable by default
The pom.xml for flink-quickstart-java and flink-quickstart-scala must
specify scala.version and scala.binary.version.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3910: [FLINK-6582] [docs] Project from maven archetype is not b...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3910
@rmetzger what is happening in `create_release_files.sh:deploy_to_maven`? Are we overwriting the 2.11 quickstart jars with 2.10 jars? Are we still looking to publish against Scala 2.10 rather than 2.11?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3910: [FLINK-6582] [docs] Project from maven archetype is not b...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3910
the change *looks* good to merge. I'm currently building Flink to quickly try it out
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3910: [FLINK-6582] [docs] Project from maven archetype is not b...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3910
Thank you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3910: [FLINK-6582] [docs] Project from maven archetype is not b...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3910
Not sure what's happening, but when I'm trying to generate a project from the archetype, I'm getting:
```
Failed to execute goal org.apache.maven.plugins:maven-archetype-plugin:2.4:generate (default-cli) on project standalone-pom: The defined artifact is not an archetype
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3910: [FLINK-6582] [docs] Project from maven archetype is not b...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3910
@rmetzger I am seeing the same issue and will look into this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3910: [FLINK-6582] [docs] Project from maven archetype is not b...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3910
After asking the question I added the second commit which inherits the scala version as is the current / expected behavior.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3910: [FLINK-6582] [docs] Project from maven archetype is not b...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3910
The script is deploying scala 2.10 for the quickstarts, yes.
I think the reason for this is that scala 2.10 is still considered "default" in Flink.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3910: [FLINK-6582] [docs] Project from maven archetype is not b...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3910
Thanks a lot for fixing the issue.
I've tested it again, and it works.
Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3910: [FLINK-6582] [docs] Project from maven archetype is not b...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3910
@rmetzger latest commit is simpler and tested successfully for java and scala: `mvn org.apache.maven.plugins:maven-archetype-plugin:2.4:generate -DarchetypeGroupId=org.apache.flink -DarchetypeArtifactId=flink-quickstart-java -DarchetypeCatalog=local -DarchetypeVersion=1.4-SNAPSHOT`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3910: [FLINK-6582] [docs] Project from maven archetype i...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3910
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---