You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gaurav Aradhye <ga...@clogeny.com> on 2013/06/20 15:53:30 UTC

Review Request: Fix for CLOUDSTACK-3021: fixed for TesttemplateHierachy.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11994/
-----------------------------------------------------------

Review request for cloudstack and Prasanna Santhanam.


Description
-------

Fixed Issue 3021 for TesttemplateHierarchy too.
Link: https://issues.apache.org/jira/browse/CLOUDSTACK-3021

Also fixed one indentation issue. The indentation of cleanup list (self._cleanup) in TestServiceOfferingHierarchy was wrong.


Diffs
-----

  test/integration/component/test_accounts.py 39ff3ea 

Diff: https://reviews.apache.org/r/11994/diff/


Testing
-------


Thanks,

Gaurav Aradhye

Re: Review Request: Fix for CLOUDSTACK-3021: fixed for TesttemplateHierachy.

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11994/#review22241
-----------------------------------------------------------


Commit 4c51c60ef7517a7719764da94d81cd082caafdf9 in branch refs/heads/master from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=4c51c60 ]

CLOUDSTACK-3021: Order removal of resources

Sub domain removed before parent domain. Also fixed indentation issue in
cleanup list of class TestServiceOfferingHierarchy

Signed-off-by: Prasanna Santhanam <ts...@apache.org>


- ASF Subversion and Git Services


On June 20, 2013, 1:53 p.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11994/
> -----------------------------------------------------------
> 
> (Updated June 20, 2013, 1:53 p.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Description
> -------
> 
> Fixed Issue 3021 for TesttemplateHierarchy too.
> Link: https://issues.apache.org/jira/browse/CLOUDSTACK-3021
> 
> Also fixed one indentation issue. The indentation of cleanup list (self._cleanup) in TestServiceOfferingHierarchy was wrong.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_accounts.py 39ff3ea 
> 
> Diff: https://reviews.apache.org/r/11994/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: Review Request 11994: Fix for CLOUDSTACK-3021: fixed for TesttemplateHierachy.

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11994/#review23825
-----------------------------------------------------------


Commit c6d9919c881cf27f7be4de541635acf649a6d910 in branch refs/heads/4.2 from Prasanna Santhanam
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c6d9919 ]

CLOUDSTACK-3021: Do not delete the domain

We delete the accounts within the domain thereby cleaning up resources.
Also corrected the typo in the test description. ForceDelete test was
called without force option and vice versa

Signed-off-by: Prasanna Santhanam <ts...@apache.org>


- ASF Subversion and Git Services


On June 20, 2013, 1:53 p.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11994/
> -----------------------------------------------------------
> 
> (Updated June 20, 2013, 1:53 p.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Fixed Issue 3021 for TesttemplateHierarchy too.
> Link: https://issues.apache.org/jira/browse/CLOUDSTACK-3021
> 
> Also fixed one indentation issue. The indentation of cleanup list (self._cleanup) in TestServiceOfferingHierarchy was wrong.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_accounts.py 39ff3ea 
> 
> Diff: https://reviews.apache.org/r/11994/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: Review Request 11994: Fix for CLOUDSTACK-3021: fixed for TesttemplateHierachy.

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11994/#review23826
-----------------------------------------------------------


Commit e432ce6f774faa9d8d0832951910310a3a3c5027 in branch refs/heads/master from Prasanna Santhanam
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=e432ce6 ]

CLOUDSTACK-3021: Do not delete the domain

We delete the accounts within the domain thereby cleaning up resources.
Also corrected the typo in the test description. ForceDelete test was
called without force option and vice versa

Signed-off-by: Prasanna Santhanam <ts...@apache.org>
(cherry picked from commit a3c21b3682db51986e7cc54d8f25b1dbf4ae9eaa)


- ASF Subversion and Git Services


On June 20, 2013, 1:53 p.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11994/
> -----------------------------------------------------------
> 
> (Updated June 20, 2013, 1:53 p.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Fixed Issue 3021 for TesttemplateHierarchy too.
> Link: https://issues.apache.org/jira/browse/CLOUDSTACK-3021
> 
> Also fixed one indentation issue. The indentation of cleanup list (self._cleanup) in TestServiceOfferingHierarchy was wrong.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_accounts.py 39ff3ea 
> 
> Diff: https://reviews.apache.org/r/11994/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: Review Request: Fix for CLOUDSTACK-3021: fixed for TesttemplateHierachy.

Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11994/#review22242
-----------------------------------------------------------

Ship it!


4c51c60

- Prasanna Santhanam


On June 20, 2013, 1:53 p.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11994/
> -----------------------------------------------------------
> 
> (Updated June 20, 2013, 1:53 p.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Description
> -------
> 
> Fixed Issue 3021 for TesttemplateHierarchy too.
> Link: https://issues.apache.org/jira/browse/CLOUDSTACK-3021
> 
> Also fixed one indentation issue. The indentation of cleanup list (self._cleanup) in TestServiceOfferingHierarchy was wrong.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_accounts.py 39ff3ea 
> 
> Diff: https://reviews.apache.org/r/11994/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: Review Request 11994: Fix for CLOUDSTACK-3021: fixed for TesttemplateHierachy.

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11994/#review23836
-----------------------------------------------------------


Commit e432ce6f774faa9d8d0832951910310a3a3c5027 in branch refs/heads/ldapplugin from Prasanna Santhanam
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=e432ce6 ]

CLOUDSTACK-3021: Do not delete the domain

We delete the accounts within the domain thereby cleaning up resources.
Also corrected the typo in the test description. ForceDelete test was
called without force option and vice versa

Signed-off-by: Prasanna Santhanam <ts...@apache.org>
(cherry picked from commit a3c21b3682db51986e7cc54d8f25b1dbf4ae9eaa)


- ASF Subversion and Git Services


On June 20, 2013, 1:53 p.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11994/
> -----------------------------------------------------------
> 
> (Updated June 20, 2013, 1:53 p.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Fixed Issue 3021 for TesttemplateHierarchy too.
> Link: https://issues.apache.org/jira/browse/CLOUDSTACK-3021
> 
> Also fixed one indentation issue. The indentation of cleanup list (self._cleanup) in TestServiceOfferingHierarchy was wrong.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_accounts.py 39ff3ea 
> 
> Diff: https://reviews.apache.org/r/11994/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>