You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2015/07/27 18:24:57 UTC

svn commit: r1692907 - in /pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/pdfdebugger: fontencodingpane/FontEncodingView.java fontencodingpane/Type0Font.java streampane/StreamImageView.java

Author: tilman
Date: Mon Jul 27 16:24:57 2015
New Revision: 1692907

URL: http://svn.apache.org/r1692907
Log:
PDFBOX-2530: fix SonarQube issues, as done by Khyrul Bashar in GSoC2015

Modified:
    pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/pdfdebugger/fontencodingpane/FontEncodingView.java
    pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/pdfdebugger/fontencodingpane/Type0Font.java
    pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/pdfdebugger/streampane/StreamImageView.java

Modified: pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/pdfdebugger/fontencodingpane/FontEncodingView.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/pdfdebugger/fontencodingpane/FontEncodingView.java?rev=1692907&r1=1692906&r2=1692907&view=diff
==============================================================================
--- pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/pdfdebugger/fontencodingpane/FontEncodingView.java (original)
+++ pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/pdfdebugger/fontencodingpane/FontEncodingView.java Mon Jul 27 16:24:57 2015
@@ -119,7 +119,7 @@ class FontEncodingView
         return panel;
     }
 
-    private final class GlyphCellRenderer implements TableCellRenderer
+    private static final class GlyphCellRenderer implements TableCellRenderer
     {
 
         @Override

Modified: pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/pdfdebugger/fontencodingpane/Type0Font.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/pdfdebugger/fontencodingpane/Type0Font.java?rev=1692907&r1=1692906&r2=1692907&view=diff
==============================================================================
--- pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/pdfdebugger/fontencodingpane/Type0Font.java (original)
+++ pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/pdfdebugger/fontencodingpane/Type0Font.java Mon Jul 27 16:24:57 2015
@@ -37,7 +37,7 @@ import org.apache.pdfbox.pdmodel.font.PD
  */
 class Type0Font implements FontPane
 {
-    FontEncodingView view;
+    private FontEncodingView view;
 
     /**
      * Constructor.

Modified: pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/pdfdebugger/streampane/StreamImageView.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/pdfdebugger/streampane/StreamImageView.java?rev=1692907&r1=1692906&r2=1692907&view=diff
==============================================================================
--- pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/pdfdebugger/streampane/StreamImageView.java (original)
+++ pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/pdfdebugger/streampane/StreamImageView.java Mon Jul 27 16:24:57 2015
@@ -42,7 +42,7 @@ import org.apache.pdfbox.tools.pdfdebugg
  */
 class StreamImageView implements ActionListener, AncestorListener
 {
-    private BufferedImage image;
+    private final BufferedImage image;
     private JScrollPane scrollPane;
     private JLabel label;
     private ZoomMenu zoomMenu;