You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/04/28 14:26:37 UTC
[GitHub] [beam] riteshghorse opened a new pull request, #17491: Add default classpath when not present
riteshghorse opened a new pull request, #17491:
URL: https://github.com/apache/beam/pull/17491
This PR adds a small enhancement to specifying additional dependency jars to JDBC IO. As discussed in #17216, we don't want users to specify both driver class name and the classpath when using a default driver jar. Integration tested by modifying [expand.go](https://github.com/apache/beam/blob/b0e6b561683425fe865720970ce60d45ecec11e4/sdks/go/pkg/beam/core/runtime/xlangx/expand.go#L148) to use version `2.38.0` instead of `core.SdkVersion`.
change
`jarPath, err := expansionx.GetBeamJar(gradleTarget, core.SdkVersion)`
to
`jarPath, err := expansionx.GetBeamJar(gradleTarget, "2.38.0")`
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #17491: Add default classpath when not present
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #17491:
URL: https://github.com/apache/beam/pull/17491#issuecomment-1112430681
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #17491: Add default classpath when not present
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17491:
URL: https://github.com/apache/beam/pull/17491#issuecomment-1112274672
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #17491: Add default classpath when not present
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17491:
URL: https://github.com/apache/beam/pull/17491#issuecomment-1112274675
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #17491: Add default classpath when not present
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #17491:
URL: https://github.com/apache/beam/pull/17491#issuecomment-1112395057
R: @youngoli for final approval
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #17491: Add default classpath when not present
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #17491:
URL: https://github.com/apache/beam/pull/17491#issuecomment-1112279987
# [Codecov](https://codecov.io/gh/apache/beam/pull/17491?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17491](https://codecov.io/gh/apache/beam/pull/17491?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0068097) into [master](https://codecov.io/gh/apache/beam/commit/b0e6b561683425fe865720970ce60d45ecec11e4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b0e6b56) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #17491 +/- ##
=======================================
Coverage 73.83% 73.83%
=======================================
Files 690 690
Lines 90830 90830
=======================================
Hits 67064 67064
Misses 22557 22557
Partials 1209 1209
```
| Flag | Coverage Δ | |
|---|---|---|
| go | `49.94% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/17491?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/17491?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b0e6b56...0068097](https://codecov.io/gh/apache/beam/pull/17491?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] riteshghorse commented on pull request #17491: Add default classpath when not present
Posted by GitBox <gi...@apache.org>.
riteshghorse commented on PR #17491:
URL: https://github.com/apache/beam/pull/17491#issuecomment-1112429541
R: @lostluck
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #17491: Add default classpath when not present
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #17491:
URL: https://github.com/apache/beam/pull/17491#issuecomment-1112324244
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @jrmccluskey for label go.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on a diff in pull request #17491: Add default classpath when not present
Posted by GitBox <gi...@apache.org>.
lostluck commented on code in PR #17491:
URL: https://github.com/apache/beam/pull/17491#discussion_r861287259
##########
sdks/go/pkg/beam/io/xlang/jdbcio/jdbc.go:
##########
@@ -236,6 +254,9 @@ func WriteToPostgres(s beam.Scope, tableName, jdbcUrl, username, password string
// jdbcUrl := "jdbc:postgresql://localhost:5432/dbname"
// outT := reflect.TypeOf((*JdbcTestRow)(nil)).Elem()
// jdbcio.Read(s, tableName, driverClassName, jdbcurl, username, password, outT, jdbcio.ExpansionAddrRead("localhost:9000"))
+//
+// With Classpath paramater:
Review Comment:
```suggestion
// With Classpath parameter:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck merged pull request #17491: Add default classpath when not present
Posted by GitBox <gi...@apache.org>.
lostluck merged PR #17491:
URL: https://github.com/apache/beam/pull/17491
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org