You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by dhatchayani <gi...@git.apache.org> on 2018/05/08 07:11:48 UTC
[GitHub] carbondata pull request #2280: [WIP] Remove unnecessary TableProvider interf...
GitHub user dhatchayani opened a pull request:
https://github.com/apache/carbondata/pull/2280
[WIP] Remove unnecessary TableProvider interface
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dhatchayani/carbondata tablePro
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2280.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2280
----
commit adf240d9c6fc8ff7541f75a2e1f77939de8e3925
Author: dhatchayani <dh...@...>
Date: 2018-05-08T07:10:59Z
[WIP] Remove unnecessary TableProvider interface
----
---
[GitHub] carbondata issue #2280: [CARBONDATA-2458] Remove unnecessary TableProvider i...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2280
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4575/
---
[GitHub] carbondata issue #2280: [WIP][CARBONDATA-2458] Remove unnecessary TableProvi...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2280
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4572/
---
[GitHub] carbondata issue #2280: [WIP][CARBONDATA-2458] Remove unnecessary TableProvi...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2280
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4796/
---
[GitHub] carbondata pull request #2280: [WIP] Remove unnecessary TableProvider interf...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2280#discussion_r186693004
--- Diff: core/src/main/java/org/apache/carbondata/core/scan/executor/util/QueryUtil.java ---
@@ -277,7 +275,7 @@ private static void addChildrenBlockIndex(Set<Integer> blockIndexes, CarbonDimen
*/
public static Map<String, Dictionary> getDimensionDictionaryDetail(
List<ProjectionDimension> queryDimensions, Set<CarbonDimension> filterComplexDimensions,
- AbsoluteTableIdentifier absoluteTableIdentifier, TableProvider tableProvider)
+ AbsoluteTableIdentifier absoluteTableIdentifier, CarbonTable carbonTable)
--- End diff --
Do you need to keep both AbsoluteTableIdentifier and CarbonTable?
---
[GitHub] carbondata pull request #2280: [WIP] Remove unnecessary TableProvider interf...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2280#discussion_r186693193
--- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/resolver/resolverinfo/visitor/RangeDictionaryColumnVisitor.java ---
@@ -49,7 +49,7 @@ public void populateFilterResolvedInfo(ColumnResolvedFilterInfo visitableObj,
resolvedFilterObject = FilterUtil
.getFilterListForAllValues(metadata.getTableIdentifier(), metadata.getExpression(),
metadata.getColumnExpression(), metadata.isIncludeFilter(),
- metadata.getTableProvider(), true);
+ null, true);
--- End diff --
table is null?
---
[GitHub] carbondata issue #2280: [WIP][CARBONDATA-2458] Remove unnecessary TableProvi...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2280
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5734/
---
[GitHub] carbondata issue #2280: [WIP] Remove unnecessary TableProvider interface
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2280
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5726/
---
[GitHub] carbondata pull request #2280: [CARBONDATA-2458] Remove unnecessary TablePro...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2280
---
[GitHub] carbondata issue #2280: [CARBONDATA-2458] Remove unnecessary TableProvider i...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/2280
LGTM
---
[GitHub] carbondata pull request #2280: [WIP] Remove unnecessary TableProvider interf...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2280#discussion_r186693055
--- Diff: core/src/main/java/org/apache/carbondata/core/scan/executor/util/QueryUtil.java ---
@@ -341,16 +339,15 @@ private static void getChildDimensionDictionaryDetail(CarbonDimension queryDimen
* @throws IOException
*/
private static Map<String, Dictionary> getDictionaryMap(List<String> dictionaryColumnIdList,
- AbsoluteTableIdentifier absoluteTableIdentifier, TableProvider tableProvider)
+ AbsoluteTableIdentifier absoluteTableIdentifier, CarbonTable carbonTable)
--- End diff --
Do you need to keep both AbsoluteTableIdentifier and CarbonTable?
---
[GitHub] carbondata issue #2280: [WIP] Remove unnecessary TableProvider interface
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2280
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4565/
---
[GitHub] carbondata issue #2280: [CARBONDATA-2458] Remove unnecessary TableProvider i...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2280
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4798/
---