[jira] [Commented] (AVRO-2112) c# (.net) port to .NET Standard 2.0 and nuget (package) dependencies

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AVRO-2112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16741235#comment-16741235 ] 

ASF subversion and git services commented on AVRO-2112:
-------------------------------------------------------

Commit 9a05375436385b7fce75d32cfdcd359e279e0628 in avro's branch refs/heads/master from Brian Lachniet
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=9a05375 ]

AVRO-2112: Target .NET Standard/Core in C# (#307)

* AVRO-2161: Upgrade C# unit tests to NUnit 3

* AVRO-2112: Update C# projects to target .NET Standard/Core and .NET Framework 4.0

* AVRO-2112: Move C# IPC tests to a Avro.ipc.test

* AVRO-2112: Ignore C# tests that use System.CodeDom compilation when targeting .NET Core

See https://github.com/dotnet/corefx/issues/12180

* AVRO-2112: Replace usage of JToken.ToString() in C# projects

In Newtonsoft.Json v3.5, JToken.ToString() returned the raw JSON
representation of the token. In later versions of
Newtonsoft.Json, JToken.ToString() returns a simple string
representation of the value. See the examples below:
- v3.5: "\"Hello World\""
- Later versions: "Hello World"

In this commit, I've updated the project to work with later versions
of Newtonsoft.Json as well as v3.5. I've replaced some usages of
JToken.ToString(). When we need the raw JSON representation, we use
JsonConvert.Serialize(). When we need the string value of a string
JToken, we use JToken.Value<string>().

* AVRO-2112: Update C# README

* Update pom.xml with new C# paths to ignore for license check

* csharp: Cut support for net35, update Dockerfile and csharp build.sh

* Add mono-complete to Dockerfile for build

* csharp: Remove unnecessary ProjectGuid elements from projects

* Revert to only running tests for Avro.test.dll

This is what we were doing on master. I was trying to run the IPC tests,
but that has not seemed to work well in our automated builds.

* List all tests as they are run

* Add build.ps1 and update README

* Update Target Frameworks table in README

* Try disabling tests that take a long time to run


> c# (.net) port to .NET Standard 2.0 and nuget (package) dependencies
> --------------------------------------------------------------------
>
>                 Key: AVRO-2112
>                 URL: https://issues.apache.org/jira/browse/AVRO-2112
>             Project: Apache Avro
>          Issue Type: Improvement
>          Components: csharp
>         Environment: - Visual Studio For Mac
> - Visual Studio 2017
> - mono 5.4.1.7 MacOSX
> - dotnet 2.0 (MacOSX and Windows 10)
>            Reporter: Miljenko Cvjetko
>            Assignee: Miljenko Cvjetko
>            Priority: Minor
>             Fix For: 1.9.0
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> Suugestion is to add .NET Standard/Core support.
> In order to support modern/new .NET (both standard netfx and dotnet core) it is necessary to convert projects to support .NET Standard Libraries. 
> - conversion to .NET Standard [DONE]
> - added dotnet core sample (Avro.perf) [DONE]
> - added netfx (standrd .NET) sample Avro.perf.netfx [DONE]
> - unit testing updated to use NUnit 3
> Url for the github forked repo with branch will be added.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)