[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #6862: GEODE-8192: Make Radish MSET command atomic

[GitBox <gi...@apache.org>]

jdeppe-pivotal commented on a change in pull request #6862:
URL: https://github.com/apache/geode/pull/6862#discussion_r710473307



##########
File path: geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/RegionProvider.java
##########
@@ -124,11 +125,13 @@ public RegionProvider(InternalCache cache, StripedCoordinator stripedCoordinator
     dataRegion = redisDataRegionFactory.create(REDIS_DATA_REGION);
     partitionedRegion = (PartitionedRegion) dataRegion;
 
-    stringCommands = new RedisStringCommandsFunctionExecutor(this);
-    setCommands = new RedisSetCommandsFunctionExecutor(this);
-    hashCommands = new RedisHashCommandsFunctionExecutor(this);
-    sortedSetCommands = new RedisSortedSetCommandsFunctionExecutor(this);
-    keyCommands = new RedisKeyCommandsFunctionExecutor(this);
+    CacheTransactionManager txManager = cache.getCacheTransactionManager();
+
+    stringCommands = new RedisStringCommandsFunctionExecutor(this, txManager);

Review comment:
       Yes, I like that idea!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org