[GitHub] [spark] warrenzhu25 commented on pull request #37716: [SPARK-40269][CORE] Randomize the orders of peer in BlockManagerDecommissioner

[GitBox <gi...@apache.org>]

warrenzhu25 commented on PR #37716:
URL: https://github.com/apache/spark/pull/37716#issuecomment-1238696830

   > Thank you for pinging me, @warrenzhu25 . Could you try to add a test case for this please?
   
   if want to verify the `newPeers` is randomized, we might need to expose `newPeers`  as `val`. Do you think it's acceptable? Or should we skip this straightforward unit test instead of introducing one method?  
   
   I checked other usage of `Utils.randomize` in `ShuffleBlcokFetchIterator`. It seems it also don't have unit test to cover this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org