[GitHub] [superset] hughhhh commented on a diff in pull request #22764: fix(ssh-tunnel): update fields for open tunnel with private + private key passwords

[GitBox <gi...@apache.org>]

hughhhh commented on code in PR #22764:
URL: https://github.com/apache/superset/pull/22764#discussion_r1073500346


##########
superset/extensions/ssh.py:
##########
@@ -63,8 +63,8 @@ def create_tunnel(
         elif ssh_tunnel.private_key:
             private_key_file = StringIO(ssh_tunnel.private_key)
             private_key = RSAKey.from_private_key(private_key_file)
-            params["private_key"] = private_key
-            params["private_key_password"] = ssh_tunnel.private_key_password
+            params["ssh_pkey"] = private_key
+            params["ssh_private_key_password"] = ssh_tunnel.private_key_password

Review Comment:
   Let's cut a ticket for this as well on our end



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org