You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/08/31 15:51:38 UTC

[GitHub] azagrebin commented on a change in pull request #6567: [FLINK-10074] Allowable number of checkpoint failures

azagrebin commented on a change in pull request #6567: [FLINK-10074] Allowable number of checkpoint failures
URL: https://github.com/apache/flink/pull/6567#discussion_r214384222
 
 

 ##########
 File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/CheckpointExceptionHandlerConfigurationTest.java
 ##########
 @@ -63,6 +63,10 @@ private void testConfigForwarding(boolean failOnException) throws Exception {
 		environment.setTaskStateManager(new TestTaskStateManager());
 		environment.getExecutionConfig().setFailTaskOnCheckpointError(expectedHandlerFlag);
 
+		if (failOnException) {
+			environment.getExecutionConfig().setTaskTolerableCheckpointFailuresNumber(3);
 
 Review comment:
   this can be always set, as it should be just ignored if `failOnException` is `false`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services