[GitHub] [kafka] rhauch commented on pull request #8654: KAFKA-9931: Implement KIP-605 to expand support for Connect worker internal topic configurations

[GitBox <gi...@apache.org>]

rhauch commented on pull request #8654:
URL: https://github.com/apache/kafka/pull/8654#issuecomment-628682601


   BTW, I've improved the error message when Connect's `TopicAdmin` fails to create a topic because of an unknown topic setting:
   
   > Uncaught exception in herder work thread, exiting:  (org.apache.kafka.connect.runtime.distributed.DistributedHerder:297)
   org.apache.kafka.connect.errors.ConnectException: Unable to create topic(s) 'mm2-offsets.backup.internal': Unknown topic config name: topic.replication.factor
   
   
   Here's what this looks like in the log message just before the herder exits:
   ```
   [2020-05-14 09:36:22,348] ERROR [Worker clientId=connect-2, groupId=backup-mm2] Uncaught exception in herder work thread, exiting:  (org.apache.kafka.connect.runtime.distributed.DistributedHerder:297)
   org.apache.kafka.connect.errors.ConnectException: Unable to create topic(s) 'mm2-offsets.backup.internal': Unknown topic config name: topic.replication.factor
   	at org.apache.kafka.connect.util.TopicAdmin.createTopics(TopicAdmin.java:305)
   	at org.apache.kafka.connect.storage.KafkaOffsetBackingStore$1.run(KafkaOffsetBackingStore.java:105)
   	at org.apache.kafka.connect.util.KafkaBasedLog.start(KafkaBasedLog.java:128)
   	at org.apache.kafka.connect.storage.KafkaOffsetBackingStore.start(KafkaOffsetBackingStore.java:115)
   	at org.apache.kafka.connect.runtime.Worker.start(Worker.java:186)
   	at org.apache.kafka.connect.runtime.AbstractHerder.startServices(AbstractHerder.java:123)
   	at org.apache.kafka.connect.runtime.distributed.DistributedHerder.run(DistributedHerder.java:284)
   	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
   	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
   	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
   	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
   	at java.lang.Thread.run(Thread.java:748)
   Caused by: org.apache.kafka.common.errors.InvalidConfigurationException: Unknown topic config name: topic.replication.factor
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org