You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/01/16 14:42:01 UTC

[GitHub] [incubator-nuttx] fjpanag opened a new pull request #2698: Added color output to syslog.

fjpanag opened a new pull request #2698:
URL: https://github.com/apache/incubator-nuttx/pull/2698


   ## Summary
   Adds coloring to syslog output.
   
   ## Impact
   None, defaults to old behaviour.
   
   ## Testing
   Tested on custom STM32F4 target, on Fedora 33 with minicom.  
   By default, minicom does not display colors, but corretly handles escapes (so the formatting remains correct).  
   Running `minicom -c on` correctly displays all colors and styles.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] btashton commented on pull request #2698: Added color output to syslog.

Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #2698:
URL: https://github.com/apache/incubator-nuttx/pull/2698#issuecomment-761619910


   I tried using the github resolve conflict tool which is actually really nice to quickly fix the conflict, but it looks like it uses merge instead of rebase so creates a merge commit.  So probably best if @fjpanag just force pushes a rebase.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] btashton merged pull request #2698: Added color output to syslog.

Posted by GitBox <gi...@apache.org>.
btashton merged pull request #2698:
URL: https://github.com/apache/incubator-nuttx/pull/2698


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] btashton commented on pull request #2698: Added color output to syslog.

Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #2698:
URL: https://github.com/apache/incubator-nuttx/pull/2698#issuecomment-761844777


   I went back and forth because the timestamp was not colored so I went for consistency. I'll leave that up to you. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2698: Added color output to syslog.

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #2698:
URL: https://github.com/apache/incubator-nuttx/pull/2698#issuecomment-761863095


   BTW, @fjpanag it's better to move pid before priority.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] fjpanag commented on pull request #2698: Added color output to syslog.

Posted by GitBox <gi...@apache.org>.
fjpanag commented on pull request #2698:
URL: https://github.com/apache/incubator-nuttx/pull/2698#issuecomment-761834122


   @btashton Thank you for merging this!
   
   However, I believe that we should re-arrage the order that the fields are printed. For example, shall the priority also be colored?
   
   May I create a new PR for this?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2698: Added color output to syslog.

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #2698:
URL: https://github.com/apache/incubator-nuttx/pull/2698#issuecomment-761625421


   @btashton let's merge @fjpanag's one first, @anchao should be sleeping now:).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] fjpanag commented on pull request #2698: Added color output to syslog.

Posted by GitBox <gi...@apache.org>.
fjpanag commented on pull request #2698:
URL: https://github.com/apache/incubator-nuttx/pull/2698#issuecomment-761624667


   If we rebase simultaneously with anchao, there will be a conflict again.
   
   @anchao shall you be first? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] fjpanag commented on pull request #2698: Added color output to syslog.

Posted by GitBox <gi...@apache.org>.
fjpanag commented on pull request #2698:
URL: https://github.com/apache/incubator-nuttx/pull/2698#issuecomment-761626259


   I am on mobile now, with no access to computer.
   
   Tomorrow morning I will be at the office again.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] btashton commented on pull request #2698: Added color output to syslog.

Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #2698:
URL: https://github.com/apache/incubator-nuttx/pull/2698#issuecomment-761625444


   @fjpanag since you seem to be around now why don't you push first and I'll make sure to merge when it passes. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] fjpanag commented on pull request #2698: Added color output to syslog.

Posted by GitBox <gi...@apache.org>.
fjpanag commented on pull request #2698:
URL: https://github.com/apache/incubator-nuttx/pull/2698#issuecomment-762122885


   @xiaoxiang781216 @btashton Please have a look at #2710.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org